Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent events for panning when image has reached the boundary #509

Open
Frrede opened this issue Sep 27, 2024 · 1 comment
Open

Comments

@Frrede
Copy link

Frrede commented Sep 27, 2024

Is your feature request related to a problem? Please describe.
I want to use react-zoom-pan-pinch inside of a carousel and whenever the image can't be dragged more to a direction the events should be passed to the carousel library so the mouse drag will move the carousel instead.

Describe the solution you'd like
Whenever the image can't be dragged more all events will not be prevented but passed through again as if panning={{disabled: true}} is set.

Describe alternatives you've considered
Don't have any.

Additional context
See here. When the image can't get moved more the events should not be prevented anymore. So even a browser scroll could work again when the image has reached the boundary.
panning

@k-ruben
Copy link

k-ruben commented Oct 25, 2024

stuck on the same problem. I want to scroll the page, when the limit is reached. I guess I could implement it myself by disabling the library when a boundary is reached and the drag is in this direction? For me this is a particular dealbreaker with this library since the image covers most of the viewport. So the user can't effectively navigate the page any further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants