Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't be emitting a message inside of try/catch #6

Open
selfcontained opened this issue Apr 25, 2016 · 0 comments
Open

Shouldn't be emitting a message inside of try/catch #6

selfcontained opened this issue Apr 25, 2016 · 0 comments
Labels

Comments

@selfcontained
Copy link
Contributor

We wrap a JSON.parse() inside of a try/catch - but also emit a user-facing event there inside of the try/catch. This can make debugging errors difficult, as it looks as though it's coming from a JSON.parse issue. We should probably move the event emitting to outside of the try/catch block, if we parsed the message successfully.

https://github.com/BeepBoopHQ/beepboop-js/blob/master/lib/resourcer.js#L114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant