Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove show VV to player #11845

Open
PowerfulBacon opened this issue Nov 6, 2024 · 3 comments
Open

Remove show VV to player #11845

PowerfulBacon opened this issue Nov 6, 2024 · 3 comments
Labels
Triaged Issues that are exempt from the stale action

Comments

@PowerfulBacon
Copy link
Member

This is just a stupid option and can reveal sensitive information if a datum is accidentally shown to a player. Exposing admin tools produces huge security risks too.

@PowerfulBacon PowerfulBacon added the Triaged Issues that are exempt from the stale action label Nov 6, 2024
@Tsar-Salat
Copy link
Contributor

Was linking datums in asay ever added? I had a PR for it once, but I forget.

I think that would deprecate any remaining uses for this.

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Nov 7, 2024

It can't be accidently shown, and players can't edit it. only viewing it.
I feel this works as is enough? Contributors with no code perm might need to know what's going on for their TM'ed PR, and that serves the purpose well.

there might be some types that shouldn't be shown to players. would it be enough to put some protections onto such?
like, we'd not want to "show vv to player" of /client or /admin_holder, smh.

@PowerfulBacon
Copy link
Member Author

I don't see a reason to be ever showing this, even for non admin contributors. I don't trust admins not to accidentally reveal sensitive info and this whole think is a giant security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged Issues that are exempt from the stale action
Projects
None yet
Development

No branches or pull requests

3 participants