Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAIT_STUNRESISTANCE does nothing. #11828

Open
PowerfulBacon opened this issue Nov 2, 2024 · 2 comments
Open

TRAIT_STUNRESISTANCE does nothing. #11828

PowerfulBacon opened this issue Nov 2, 2024 · 2 comments

Comments

@PowerfulBacon
Copy link
Member

Rust regen and pumpup from the syndicate item uses TRAIT_STUNRESISTANCE which doesn't do anything.

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented Nov 9, 2024

Appears to have been added here in

Seems to be traceable to a TG pr, which added a reorganizing of how batoning works. A trait check occurs on baton attack end.

Cenrus just ported the definition, he literally wrote it no where else. The pr linked wasnt ported, he just included the new trait for some reason?

Then a few years later, Lamiales added TG's heretic system, including adding traits that hook into this "new" stun system. A system we do not have.

So yea.

@PowerfulBacon
Copy link
Member Author

I am currently in the process of refactoring traits to add value traits, stun resistance will be merged with these so that the trait applies modifiers rather than full or no resistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants