Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All UAM vehicle events should be labelled with mode "uam" instead of "car" #13

Open
RRothfeld opened this issue Mar 21, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@RRothfeld
Copy link
Collaborator

No description provided.

@Aitanm
Copy link
Contributor

Aitanm commented Mar 26, 2019

This is only happening when the agent is a vehicle. For example: <event time="22408.0" type="arrival" person="uam_vh_00-01" link="uam_sl-uam_st_00_ga-uam_st_00_fa" legMode="car" />.
For passengers it is correctly labelled as "uam" in the events file.
I believe this is because we create the passengers' legs in the OptimizedUAMIntermodalRoutingModule, and there, every leg has its own label depending on the mode. For the vehicles, the DVRP framework is used, and the leg created in the UAMActionCreator is a VrpLeg. The VrpLeg has only one mode, which is car. From the VrpLeg: private final String mode = TransportMode.car;.

What would be the best way to label these legs as "uam" without modifying DVRP code or rewriting the whole vrpagent package?

@RRothfeld RRothfeld transferred this issue from another repository Sep 12, 2019
@RRothfeld RRothfeld added the bug Something isn't working label Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants