-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector graphics #7
Comments
@mrikasper can you re-generate a high resolution or svg version of the in vivo figure? |
Thank you for the suggestion, @felixhorger ! The source image is already high resolution (in fact, higher resolution than the reconstruction matrix size), so I am not sure how JOSS for the paper PDF handles the conversion. If you know of any pointers how to make the conversion less lossy, I would be happy to implement it. For the README, we use a lower-resolution version of the image to reduce loading time (670kB instead of 9MB), but its resolution is still close to the actual resolution of the reconstruction matrix size. With respect to vector graphics formats, if I understand them correctly, they would not improve the quality of the pixel-based reconstruction images themselves, but only the text and lines in between. File size might be a bit smaller, but in my opinion accessibility is higher with png, because many programs and platforms can read them. All the best, |
Dear Felix @felixhorger, Thank you for this detailed response and the example code. I understand now better what you suggest: Let the reader decide on what interpolation is used for displaying a pixel matrix, rather than the author. I think ideally this is done on a programmable level like you suggest with your coding snippets. However, our ethics does not allow to share the data for the in-vivo figure at the moment, so this would not really be possible in and end-to-end way. What we could do instead is to do what you suggest for the phantom figure and save it (or its components) as All the best, |
We have reviewed the issue and it will take some time to regenerate the figure, however we will keep in mind to follow a pixel-preserving image generation pipeline in the future. In the broader list of issues identified by the review, it is minor and does not really reduce the scientific value of the submitted work, so we will address it once the other issues are resolved. |
Any chance we can get the in vivo image in the readme in higher resolution or even better as a vector graphic? 😄 I think it would then be easier to appreciate how well your reconstruction works.
Take a look here.
The text was updated successfully, but these errors were encountered: