-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLEEP-1499 Support embedding of Superset dashboard in Iaso #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madewulf
reviewed
Oct 17, 2024
madewulf
reviewed
Oct 17, 2024
madewulf
reviewed
Oct 17, 2024
madewulf
reviewed
Oct 17, 2024
- Add a new pages template that supports embedding a new type of page "SUPERSET" - Add an API endpoint POST /api/superset/token that creates a Superset "guest token" for a specific dashboard
bramj
force-pushed
the
SLEEP-1499-embed-superset
branch
from
December 6, 2024 12:28
86bf50d
to
c137bca
Compare
Added a new entry in webpack to be able to load it only on the superset.html template page.
@beygorghor What do you think of this commit? 0ef8748 @madewulf Okay for re-review! |
beygorghor
approved these changes
Dec 16, 2024
hat/assets/js/apps/Iaso/domains/pages/components/CreateEditDialog.js
Outdated
Show resolved
Hide resolved
madewulf
approved these changes
Dec 16, 2024
tdethier
added
user tested
Has already been tested on staging
ok for release
Released
and removed
ok for release
labels
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a v1 for embedding Superset dashboards in Iaso, using the
Pages
model.Specifically:
/api/superset/token
that creates a Superset "guest token" for a specific dashboardRelated JIRA tickets : https://bluesquare.atlassian.net/browse/SLEEP-1499
Note that this is a v1. In order to make this properly usable for regular users, I think we should have a place where you can configure the connection to such a dashboard for a given account.
How to test
dashboard_id
.dashboard_id
of the dashboard you want to embed.example config:
(On Trypelim, I have only the
hideTab
andhideTitle
set. Filters are useful and chart controls allow things like exporting CSV data)