Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3395: Associate a favourite picture for each Org Unit in the setuper #1692

Conversation

butofleury
Copy link
Member

@butofleury butofleury commented Oct 9, 2024

This PR has to be merged after that one : #1689

Related JIRA tickets : IA-3395

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Associating a favorite picture to each org unit with pictures in submissions.

How to test

From setuper folder, launch setuper via python3 setuper.py --additional_projects to generate test data. Then login with the created account and open Org Units page and filter on the health facility org unit type for example with name CMA Boromo. Open the org unit page and go on the IMAGES tab. You should see a seleced image for the org unit.

Print screen / video

Iaso.webm

@butofleury butofleury requested review from kemar and bramj October 9, 2024 14:05
Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butofleury butofleury merged commit ba7b247 into main Oct 11, 2024
3 checks passed
@butofleury butofleury deleted the IA-3395-Associate-a-favourite-picture-for-each-Org-Unit-in-the-setuper branch October 11, 2024 06:03
@quang-le quang-le added ok for release user tested Has already been tested on staging labels Oct 22, 2024
@quang-le
Copy link
Member

The picture is added but not as favourite, we'll open a new ticket to fix it

@butofleury
Copy link
Member Author

The picture is added but not as favourite, we'll open a new ticket to fix it

Selecting favourite picture was limited to org units belong to health facility type only. See the lines: https://github.com/BLSQ/iaso/blob/main/setuper/org_unit_pictures.py#L6C5-L12C18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants