Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3409: Planning screen do not load geographic data #1663

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

beygorghor
Copy link
Collaborator

Frontend is checking the presence of a geojson in the payload, not the has_geo_json value. Setuper is adding empty values in the geojson.... then markers are in the shapes sections

Related JIRA tickets : IA-3409

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

checking presence of geoJson and tha value of has_geo_json

How to test

Difficult to test, you can use the setuper to fille up org units and try, or edit an org unit in you db
It has been deployed on staging for test:
https://iaso-staging.bluesquare.org/dashboard/planning/assignments/accountId/156/planningId/69/team/207/baseOrgunitType/920/tab/map

Print screen / video

Screenshot 2024-10-01 at 11 53 44

@quang-le quang-le merged commit 78a8b3a into main Oct 1, 2024
4 checks passed
@quang-le quang-le deleted the IA-3409-planning-missing-markers branch October 1, 2024 10:05
@beygorghor
Copy link
Collaborator Author

@butofleury is this the wanted behaviour in the setuper while creating an org unit, geo_json is not empty and latitude and longitude are set too

@butofleury
Copy link
Member

@butofleury is this the wanted behaviour in the setuper while creating an org unit, geo_json is not empty and latitude and longitude are set too

@beygorghor , exaclty in setuper all created org units have geolocation. There was a PR for removing all org units without geolocation in the source file.

@kemar kemar added release Should be released in production at next deploy Released and removed release Should be released in production at next deploy labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants