Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3338: Add fiter "Project" on Form statistics #1606

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Sep 2, 2024

Explain what problem this PR is resolving

  • Add fiter "Project" on Form statistics
    Related JIRA tickets : IA-3338

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

  • Added projects filter on front-end form stats page
  • Add projects filter in back-end on form stats api

How to test

  • Forms --> Form statistics
  • Check if the projects filter works where

Print screen / video

Screencast.from.2024-09-02.16-59-12.webm

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

@hakifran hakifran requested a review from quang-le September 2, 2024 15:01
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of the filter and the button is off.

Screenshot 2024-09-04 at 11 08 02

Code comments are for style/good practice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsx, nice 😀

@hakifran
Copy link
Contributor Author

hakifran commented Sep 4, 2024

The alignment of the filter and the button is off.

Screenshot 2024-09-04 at 11 08 02

Code comments are for style/good practice.
Screenshot from 2024-09-04 14-32-06

@hakifran hakifran closed this Sep 4, 2024
@hakifran hakifran reopened this Sep 4, 2024
@hakifran hakifran requested a review from quang-le September 4, 2024 13:21
@beygorghor beygorghor added the release Should be released in production at next deploy label Sep 5, 2024
@hakifran hakifran merged commit fb33535 into main Sep 5, 2024
3 checks passed
@hakifran hakifran deleted the IA-3338-Add-fiter-Project-on-Form-statistics branch September 5, 2024 12:01
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants