[WC2-478] Using source_created_at and source_updated_at instead of their server… #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madewulf
changed the title
bramj
reviewed
Aug 25, 2024
iaso/api/mobile/entity.py
Outdated
| updated_at = serializers.SerializerMethodField() | ||
|
|
||
| def get_created_at(self, instance): | ||
| return instance.source_created_at.timestamp() if instance.source_created_at else None |
There was a problem hiding this comment.
This would do the trick yes, but maybe fallback to created_at just in case would be best
… equivalent for mobile entity api
to avoid sending None to the mobile app.
bramj
force-pushed
the
hotfix-updated-at-date-for-entities
branch
from
8dc4ec8 to
37e6190
Compare
when updating an instance via Enketo.
To facilitate the fetching of source_created/update_at with fallback to DB timestamps. Should make it easier to avoid mistakes in the future.
|
@madewulf I've added a fix for when a form is edited with Enketo (creation with Enketo was already okay) and I went further to ensure we have the correct timestamp, while not sending None to the mobile app. |
bramj
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket here: https://bluesquare.atlassian.net/browse/WC2-478
The problem is the wrong ordering of visits in this screen
As a solution: sending source_created_at and source_updated at to the mobile phones in the mobile entity API because we were sending the update and creation date from the server, which hides the timing between visits at WFP, which is problematic because this timing is essential to find out if a beneficiary is late.
Self proofreading checklist
How to test
Upload and download entity on the mobile app
Print screen / video