Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3339-IA-2904: Bulk creation with user role - users do not have access to anything and Add phone number column in Bulk User Creation template #1580

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Aug 23, 2024

Explain what problem this PR is resolving

  • Add phone number column in Bulk User Creation template
  • Bulk creation with user role - users do not have access to anything
    Related JIRA tickets : IA-2904, IA-3339

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • Phone number on new profile creation
  • Add phone number on the user upload file template
  • Add phone number on bulk user creation
  • Update tests to fit the added phone number

How to test

IA-3339

  • Try to create user from bulk creation and add a user role in the file
  • Connect with the new created user and check if he has access to permissions in the user role

IA-2904

  • Download the bulk creation file template
  • Add news users and add their corresponding phone number
  • Upload the file on bulk user creation
  • Check if the users phone number has been added

Print screen / video

IA-3339

Screencast from 2024-08-23 18-40-51.webm
Screencast from 2024-08-23 18-41-48.webm

IA-2904

Screencast.from.2024-08-23.18-49-19.webm

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

…r role and add Phone number on profil creation
@hakifran hakifran requested a review from quang-le August 23, 2024 16:51
@hakifran hakifran requested review from kemar and removed request for quang-le August 26, 2024 07:45
@kemar
Copy link
Member

kemar commented Aug 26, 2024

I know this wasn't done in this PR but the format is different for user_roles in the import and in the export.

Maybe we should open a new Jira tiket to fix this?

csv

Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well in local testing.

But can you add some tests for the new features of the bulk import?

iaso/api/bulk_create_users.py Outdated Show resolved Hide resolved
iaso/api/bulk_create_users.py Outdated Show resolved Hide resolved
iaso/api/fixtures/sample_bulk_user_creation.csv Outdated Show resolved Hide resolved
iaso/api/bulk_create_users.py Show resolved Hide resolved
iaso/api/bulk_create_users.py Show resolved Hide resolved
@hakifran hakifran requested a review from kemar August 28, 2024 12:14
Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Good job on testing 👍 (I know it's a bit painful)

@hakifran hakifran merged commit 4fe1814 into main Aug 28, 2024
3 checks passed
@hakifran hakifran deleted the IA-3339-IA-2904-Add-phone-number-column-in-Bulk-User-Creation-template branch August 28, 2024 14:32
@mathvdh mathvdh added release Should be released in production at next deploy Released labels Sep 10, 2024
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants