-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3339-IA-2904: Bulk creation with user role - users do not have access to anything and Add phone number column in Bulk User Creation template #1580
Conversation
…r role and add Phone number on profil creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well in local testing.
But can you add some tests for the new features of the bulk import?
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Good job on testing 👍 (I know it's a bit painful)
Explain what problem this PR is resolving
Related JIRA tickets : IA-2904, IA-3339
Self proofreading checklist
Changes
How to test
IA-3339
IA-2904
Print screen / video
IA-3339
Screencast from 2024-08-23 18-40-51.webm
Screencast from 2024-08-23 18-41-48.webm
IA-2904
Screencast.from.2024-08-23.18-49-19.webm
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here