Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastq files not found #35

Open
dfornika opened this issue Apr 9, 2021 · 2 comments
Open

fastq files not found #35

dfornika opened this issue Apr 9, 2021 · 2 comments

Comments

@dfornika
Copy link
Member

dfornika commented Apr 9, 2021

On v1.3.0, the pipeline fails to find fastq files when launched using our helper script:

The script uses the PWD environment variable to get the name of the current working directory, and use that to find the directory containing the fastq files:

https://github.com/BCCDC-PHL/covid19.analysis-helper-scripts/blob/fc07e5753d980e3fbc5754dedaf9685fb6e2401b/scripts/run-ncov2019-artic-nf-1.3#L34

This has worked on all previous versions of the helper script, but is now giving an error message:

Please supply a directory containing fastqs or CRAMs with --directory. Specify --cram if supplying a CRAMs directory
@dfornika
Copy link
Member Author

dfornika commented Apr 9, 2021

There was a change to the upstream repo on Sept. 24 related to how fastq files were found, which might be related to this issue:

connor-lab@9267579

That change has not been incorporated into this repo.

@dfornika
Copy link
Member Author

We've mitigated this issue by re-arranging the order of command-line arguments:

https://github.com/BCCDC-PHL/covid19.analysis-helper-scripts/commit/15f32f3b9da59ddc8e0c2ca12d9337c8c29916ff

I'm going to leave this issue open because I'd prefer to find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant