Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsedSpec broken for APS1 #200

Open
dieris opened this issue Mar 28, 2019 · 1 comment
Open

PulsedSpec broken for APS1 #200

dieris opened this issue Mar 28, 2019 · 1 comment
Assignees

Comments

@dieris
Copy link
Collaborator

dieris commented Mar 28, 2019

[Id(q), MEAS(q)] breaks the logic in

for ct, switchPt in enumerate(switchPts):
# skip if:
# 1) control-flow instruction or label (i.e. not a waveform)
# 2) the trigger count is too long
# 3) the previous trigger pulse entends into the current entry
while (not isinstance(miniLL_IQ[curIQIdx], APSWaveform) or
(switchPt - timePts[curIQIdx]) >
(ADDRESS_UNIT * MAX_TRIGGER_COUNT) or len(trigQueue) > 1):
# update the trigger queue, dropping triggers that have played
trigQueue = [t - miniLL_IQ[curIQIdx].length for t in trigQueue]
trigQueue = [t for t in trigQueue if t >= 0]
curIQIdx += 1
# add padding pulses if needed
if curIQIdx >= len(miniLL_IQ):
if len(trigQueue) > 0:
pad = max(MIN_ENTRY_LENGTH, min(trigQueue, 0))
else:
pad = MIN_ENTRY_LENGTH
miniLL_IQ.append(padding_entry(pad))
#Push on the trigger count
, which tries to add a padding after the GOTO instruction.

Adding any delay after MEAS sidesteps the problem.

@dieris dieris self-assigned this Mar 28, 2019
@dieris
Copy link
Collaborator Author

dieris commented Nov 25, 2019

Is it still a problem @Himorask ? I can't reproduce it with current settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant