Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the Mathieu even and odd functions #17

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Addition of the Mathieu even and odd functions #17

merged 4 commits into from
Jan 31, 2024

Conversation

mahdi-sasar
Copy link
Contributor

Hi everyone.
The old repository here only allowed for the calculation of the characteristic values of the Mathieu functions. I decided to add the actual definitions of the Mathieu sine and cosine functions using the Fourier series expansion of these functions that is available in many textbooks.
Hope this is useful and can aid others as well. I personally use them extensively now for some quantum mechanical studies where using Mathieu functions as basis sets is computationally beneficial.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (4daabb6) 97.14% compared to head (fb60c9a) 31.25%.

Files Patch % Lines
src/char-values.jl 0.00% 76 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
- Coverage   97.14%   31.25%   -65.90%     
===========================================
  Files           1        2        +1     
  Lines          35      112       +77     
===========================================
+ Hits           34       35        +1     
- Misses          1       77       +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gribeill
Copy link
Contributor

Thank you for this useful PR!

@gribeill gribeill merged commit 40a0c35 into BBN-Q:master Jan 31, 2024
3 of 5 checks passed
@mahdi-sasar
Copy link
Contributor Author

Thanks for the merge. Hope this is useful for everyone.
One question though: I am not familiar with the Codecov error that was generated. Can I help improve this somehow?

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (4daabb6) 97.14% compared to head (fb60c9a) 31.25%.

Files Patch % Lines
src/char-values.jl 0.00% 76 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants