Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the function #ray_angle_filter# in model_depth_pose.py #19

Open
Impuuuuuu opened this issue Sep 29, 2020 · 0 comments
Open

About the function #ray_angle_filter# in model_depth_pose.py #19

Impuuuuuu opened this issue Sep 29, 2020 · 0 comments

Comments

@Impuuuuuu
Copy link

Hello, followings are some question about the function # ray_angle_filter # in model_depth_pose.py.
First, when filtering out the matches around epipoles, why compute the angle betwwen vertical line from ray1 origin to ray2 and ray1 instead of the angle betwwen ray1 and the line from ray1 origin to ray2 origin?
Second, also in the function #ray_angle_filter#, when drop out angles less than 1', why apply the constraint #cosvalue > 0.001# instead #cosvalue < 0.999#, shouldn't cosvalue be smaller the the angle is turning larger?
mask = (cosvalue > 0.001).float() # we drop out angles less than 1' [b,1,n]
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant