How would the health endpoint will function with hot reload? In case of bad config it might use last good known config which might give wrong status.

Would be good to add limitations.

How would the health endpoint will function with hot reload? In case of bad config it might use last good known config which might give wrong status.

Would be good to add limitations.

I dont see an issue in this, If DAB Engine is working then health point should be consistent with that. If DAB engine is using the last known config, then health endpoint would also show the health of the last known config.
Showing health of the current config but running the engine with the last known config would create inconsistencies which would be incorrect for the user.
We should put this in documentation that we are using the last known config in case of hot reload and showing health of that old config not the bad config.

Another important point to note is.. Health is independent of Validity of config. Health endpoint is only shown when the config is valid (no errors) and DAB engine is running. So the case of bad config would not occur.

@JerryNixon , Any thoughts on this?

How would the health endpoint will function with hot reload? In case of bad config it might use last good known config which might give wrong status.
Would be good to add limitations.

I dont see an issue in this, If DAB Engine is working then health point should be consistent with that. If DAB engine is using the last known config, then health endpoint would also show the health of the last known config. Showing health of the current config but running the engine with the last known config would create inconsistencies which would be incorrect for the user. We should put this in documentation that we are using the last known config in case of hot reload and showing health of that old config not the bad config.

Another important point to note is.. Health is independent of Validity of config. Health endpoint is only shown when the config is valid (no errors) and DAB engine is running. So the case of bad config would not occur.

@JerryNixon , Any thoughts on this?

Thanks for clarifying. can you add the same to your documentation as well.