Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception messages for data source and entities #2490

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sezal98
Copy link
Contributor

@sezal98 sezal98 commented Dec 12, 2024

Why make this change?

This change is made to resolve #2480
In the above bug the validation error message is not proper to describe the error in the configs. This change would properly defined that data source and entities is a mandatory field.

Tested Multiple Scenarios

  1. Single data source file with datasource or entities section missing
  2. Multiple data source files with data source or entities section missing in top level or any of the lower level files

How was this tested?

  • [] Integration Tests
  • Unit Tests

Sample Request(s)

image image

Copy link
Contributor

@abhishekkumams abhishekkumams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few nits.

@sezal98
Copy link
Contributor Author

sezal98 commented Dec 13, 2024

/azp run

@sezal98
Copy link
Contributor Author

sezal98 commented Dec 16, 2024

/azp run

@sezal98
Copy link
Contributor Author

sezal98 commented Dec 16, 2024

/azp run

@sezal98
Copy link
Contributor Author

sezal98 commented Dec 18, 2024

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants