Added ValidateAspNetCoreUrls #2466
Conversation
JerryNixon
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
@JerryNixon , you can run |
|
/azp run |
|
The failing unit test appears to be caused by stale environment variables from one test causing another to fail due to the new validation, when that test expects the program main function to work. I was able to get the pipeline to pass on another branch (https://github.com/Azure/data-api-builder/tree/dev/aaronburtle/ASP_URL_DEBUGG) by adding in the Environment variable that you are validating to the function in test helper that unsets all DAB environment variables. This is the change that seems to fix it, which also requires that the environment variable constant be moved to the class as a public field so we can borrow its use for testhelper.
|
|
/azp run |
|
/azp run |
|
/azp run |
This pull request introduces a validation check for the
ASPNETCORE_URLSenvironment variable to ensure it is in the correct format before starting the engine in theProgramclass. This change helps in preventing runtime errors due to misconfigured URLs.Key changes:
ValidateAspNetCoreUrlsto check the format of theASPNETCORE_URLSenvironment variable. This method splits the environment variable by commas or semicolons and ensures each part is a valid absolute URI.ValidateAspNetCoreUrlsmethod into theMainmethod to validate the URLs before proceeding with the engine start. If the validation fails, an error message is printed, and the application exits with an error code.Why make this change?
The primary motivation is to return a more clear error message to the user.
Closes #2465
What is this change?
Startup validation.
How was this tested?
Sample Request(s)
Valid value in END file:
ASPNETCORE_URLS="http://localhost:5000;https://localhost:5001"Invalid value in END file:
ASPNETCORE_URLS=http://localhost:5000;https://localhost:5001