Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some dialogs aren't usable in landscape on phones #65

Closed
UsernamesAreNotMyThing opened this issue Feb 7, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working done v1.91

Comments

@UsernamesAreNotMyThing
Copy link

UsernamesAreNotMyThing commented Feb 7, 2023

Describe the bug

The buttons in certain dialogs, notably those for purchasing or using shop items, can't be seen or clicked if the full content of the dialog can't all fit on screen, and there is no way to scroll down to get there either.

To Reproduce

Steps to reproduce the behavior:

  1. Click the "buy" button for a shop item in landscape mode - you won't be able to use or see any of the buttons on the dialog

Expected behavior

The dialog should at least be able to scroll, which can be implemented really easily by using a ScrollView as the root view of the dialog and setting the existing dialog content as a child of that.

Screenshots

Screenshot_20230207-132415

Environments and Version (please complete the following information):

  • Device: Motorola Moto z4
  • OS: Android 10 (QDF30.130-42-5-17)
  • Version: v1.90.9 (400)
@UsernamesAreNotMyThing UsernamesAreNotMyThing added the bug Something isn't working label Feb 7, 2023
@Ayagikei
Copy link
Owner

Ayagikei commented Feb 8, 2023

Thanks for the feedback!

We'll investigate it.

@Ayagikei Ayagikei added working on it working on this fixing this issue to be released fixed but not released yet v1.91 and removed working on it working on this fixing this issue labels Feb 10, 2023
@Ayagikei Ayagikei added done and removed to be released fixed but not released yet labels Feb 22, 2023
@UsernamesAreNotMyThing
Copy link
Author

UsernamesAreNotMyThing commented Jun 5, 2023

Just discovered that this still occurs on the dialogs for editing coin and synthesis effects on items, and for returning items.

@Ayagikei
Copy link
Owner

Just discovered that this still occurs on the dialogs for editing coin and synthesis effects on items, and for returning items.

Get it. We will check that again.

@Ayagikei
Copy link
Owner

Just discovered that this still occurs on the dialogs for editing coin and synthesis effects on items, and for returning items.

These dialogs already support scrolling in v1.93.0-rc02.

If you find a new exception dialogs, please feel free to re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done v1.91
Projects
None yet
Development

No branches or pull requests

2 participants