Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"FIAMS Unknowns" workflow using SmartPeak on a set of mzML files #405

Closed
ParizadB opened this issue Aug 11, 2021 · 6 comments · Fixed by #455
Closed

"FIAMS Unknowns" workflow using SmartPeak on a set of mzML files #405

ParizadB opened this issue Aug 11, 2021 · 6 comments · Fixed by #455
Assignees

Comments

@ParizadB
Copy link

ParizadB commented Aug 11, 2021

Hi,

I'm trying to run the "FIAMS Unknowns" workflow using SmartPeak v1.11.0 on a Mac with macOS Big Sur Version 11.5.1. I have a set of mzMl files and when I want to run the workflow the app crashes. I have attached my most recent log file. I'd appreciate any help on that :)
smartpeak_log_2021-08-11_14-52-33.csv

@bertrandboudaud bertrandboudaud self-assigned this Aug 11, 2021
@ahmedskhalil
Copy link
Collaborator

@ahmedskhalil

@ahmedskhalil ahmedskhalil self-assigned this Aug 12, 2021
@ahmedskhalil
Copy link
Collaborator

Hi, thanks for filing the issue. we ran the file including all the workflow steps with sequence_rats.csv you provided and we could not replicate the issue, have you succeeded running similar workflow steps with the same data ?

@ParizadB
Copy link
Author

Hi,
I tried with the attached workflow which extracts features from mzML files and stores them. Still got the same problem.
feature_extraction.txt
smartpeak_log_2021-08-16_14-11-05.csv

@ParizadB ParizadB changed the title I am trying to run the "FIAMS Unknowns" workflow using SmartPeak on a set of mzML files. "FIAMS Unknowns" workflow using SmartPeak on a set of mzML files Aug 16, 2021
@ParizadB
Copy link
Author

ParizadB commented Sep 1, 2021

Here is the system report I get after the crash.
report.txt

@bertrandboudaud
Copy link
Collaborator

In the callstack, we can see Thread 11 has crashed

Thread 11 Crashed:
0   libOpenMS.dylib               	0x000000010983b773 void std::__1::__tree_remove<std::__1::__tree_node_base<void*>*>(std::__1::__tree_node_base<void*>*, std::__1::__tree_node_base<void*>*) + 35
1   libOpenMS.dylib               	0x000000010983d096 OpenMS::Logger::LogStreamBuf::addToCache_(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 966
2   libOpenMS.dylib               	0x000000010983c2b6 OpenMS::Logger::LogStreamBuf::syncLF_() + 246
3   libOpenMS.dylib               	0x000000010983d789 OpenMS::Logger::LogStreamBuf::sync() + 9
4   libc++.1.dylib                	0x00007fff203ded79 std::__1::basic_ostream<char, std::__1::char_traits<char> >::flush() + 65
5   libOpenMS.dylib               	0x0000000109a21f3e OpenMS::FeatureMap::setPrimaryMSRunPath(std::__1::vector<OpenMS::String, std::__1::allocator<OpenMS::String> > const&) + 94
6                                 	0x000000010783437b SmartPeak::PickMS1Features::process(SmartPeak::RawDataHandler&, SmartPeak::ParameterSet const&, SmartPeak::Filenames const&) const + 11995 (RawDataProcessor.cpp:2095)

this failure in std::__1::__tree_remove<std::__1::__tree_node_base<void*>*> seems to indicate a memory corruption. The "base call" is the PickMS1Features processor.

We can also see that some other threads (2 others) are executing also PickMS1Features at the same time. could we have concurrent access there or invalid memory access?

@ahmedskhalil does this callstack gives you some other clues? perhaps we can add more logs so that Parizad give you more details of the context.

@ParizadB it would be interesting to change the number of working threads to see if it make it pass. in the files you have given, we can see the number of threads is 29 which is quite high. we can have a try reducing it. may be we can set it to 1. It will be slow but it could be interesting to see if it still crashes.

the parameter is located in the parameters.csv file:
image
is it possible to change it to 1, save and re-run. if it fails, return the log and the callstack?

thank you

@ParizadB
Copy link
Author

ParizadB commented Sep 2, 2021

Running the second part of the workflow with n_thread = 4 resulted in the attached call stack
report_thread_4.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants