New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regarding isCritical Flag Change in addExtension Function #2856

Open

TakuyaMatsu opened this issue Jan 14, 2025 · 0 comments

Contributor

TakuyaMatsu commented Jan 14, 2025 •

edited

Loading

In the PR linked above, the isCritical flag was changed from true to false when calling addExtension. Was this an intentional change?
Could you explain the reason for this modification?
(Link: https://github.com/AthenZ/athenz/pull/2495/files#diff-8dfeb9396a5d5e42fb1fae377a340bcd61923b20d1bb696b0ca7136f45f6f400L1406-R1435
https://github.com/AthenZ/athenz/pull/2495/files#diff-8dfeb9396a5d5e42fb1fae377a340bcd61923b20d1bb696b0ca7136f45f6f400L1404-R1423
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment