Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahc-default.properties causes conflicts in shading #1536

Closed
wsargent opened this issue Apr 5, 2018 · 3 comments
Closed

ahc-default.properties causes conflicts in shading #1536

wsargent opened this issue Apr 5, 2018 · 3 comments
Milestone

Comments

@wsargent
Copy link
Contributor

wsargent commented Apr 5, 2018

Play-WS will shade AHC's version of Netty to ensure that other Netty libraries can be used i.e. Netty 3.x can be used with AHC Netty 4.x.

However, AHC points to /ahc-default.properties, which is hardcoded to point to the root resource. This has caused issues when people include libraries that depend on older versions of AHC, such as Dispatch or Cassandra.

playframework/play-ws#229

The ideal solution would be for AHC to do some introspection on the package and call up the current package, and then refer to <package-name>/ahc-defaults.properties -- that way it would be guaranteed local to whereever it was shaded.

@slandelle
Copy link
Contributor

PR? ;-)

@wsargent
Copy link
Contributor Author

wsargent commented Apr 5, 2018

@slandelle done

@wsargent
Copy link
Contributor Author

wsargent commented Apr 7, 2018

One thing to note -- I don't know how this is affected in OSGi environments, i.e. #1345 -- maybe @isopov can review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants