Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plagyround][server] invocation parameter defaults are missing for most models which leads to inconsistent ux #5390

Open
Tracked by #5373 ...
Parker-Stafford opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
c/server Server implementation

Comments

@Parker-Stafford
Copy link
Contributor

Parker-Stafford commented Nov 15, 2024

A couple of things:

  • invocation parameters are only captured when they are changed on instrumentation - this is fine
  • invocation parameters don't have defaults which causes numeric ones to be displayed as 0 in the ui. However 0 is not the default from the provider when they are unset, so we need to set defaults (at least for numeric params)
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Nov 15, 2024
@dosubot dosubot bot added the c/ui label Nov 15, 2024
@Parker-Stafford Parker-Stafford changed the title invocation params are only captured if changed, but we don't have defaults plumbed through for most of them for most models and providers leading to potential mismatch between what you see in the ui and what was actually used [plagyround][server] invocation parameter defaults are missing for most models which leads to inconsistent ux Nov 15, 2024
@Parker-Stafford Parker-Stafford added c/server Server implementation and removed c/ui labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Server implementation
Projects
Status: 📘 Todo
Development

No branches or pull requests

2 participants