Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation: User, System, Output #987

Open
harrisonchu opened this issue Aug 29, 2024 · 0 comments
Open

Instrumentation: User, System, Output #987

harrisonchu opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request instrumentation Adding instrumentations to open source packages

Comments

@harrisonchu
Copy link
Contributor

In the current instrumentation approach its really hard to get the actual values from:

User Prompt
System Prompt
Output

It requires you to have system level knowledge of where these values reside within the object. In the case of OpenAI they are the first index of the array of the message field. This can also vary between providers.

[BEGIN DATA]
************
[Input Question, System message and Context to AI Assistant]:
{attributes.llm.input_messages.0.message.content}

{attributes.llm.input_messages.1.message.content}
************
[AI Assistant Answer]:
{attributes.llm.output_messages.0.message.content}
 ************
[END DATA]

I'd like to suggest we have an option in implementation to copy the parameters to well known fields. This makes the downstream accessibility much much easier, with the added burden of a slight bit of copying of data.

attributes.llm.user_prompt
attributes.llm.sys_prompt
attributes.llm.output

The other option is these are short cuts for the final data locations that will have to proliferate through our software everywhere.

@harrisonchu harrisonchu transferred this issue from Arize-ai/phoenix Aug 29, 2024
@harrisonchu harrisonchu added the instrumentation Adding instrumentations to open source packages label Aug 29, 2024
@dosubot dosubot bot added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrumentation Adding instrumentations to open source packages
Projects
Status: 📘 Todo
Development

No branches or pull requests

1 participant