Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please straighten out your supported Python versions and dependencies #976

Open
sarnold opened this issue Sep 13, 2024 · 3 comments
Open

Comments

@sarnold
Copy link

sarnold commented Sep 13, 2024

I just came back to this after several years and there seems to be zero progress in terms of cleaning up Python version support or packaging. Meaning setup.py still requires future pkg even though several other places claim only py36 or later (and several variants thereof). This is getting ridiculous trying to maintain a package that won't let go of out-dated dependencies. The world moves on and even bionic has been declared lifeless. Please lurch forward into at least the early 21st century...

@peterbarker
Copy link
Contributor

I just came back to this after several years and there seems to be zero progress in terms of cleaning up Python version support or packaging. Meaning setup.py still requires future pkg even though several other places claim only py36 or later

We're not going out of our way to support Python2 any more - if it breaks it breaks.

But we are also not going out of our way to kill it right now in pymavlink. That day may come - and it will be a good day!

(and several variants thereof). This is getting ridiculous trying to maintain a package that won't let go of out-dated

I think we may be unaware of problems that our laggardly behaviour may be causing other people here.

Are you attempting to create system packages or the like?

dependencies. The world moves on and even bionic has been declared lifeless

.... python3 is a possibility on Bionic.

Please lurch forward into at least the early 21st century...

Wait, who doesn't like steam trains?

@bobpaul
Copy link

bobpaul commented Jan 13, 2025

Am I missing something? I don't see any reference to future in the *.py files in the project. I just built the package with python13 and without installing future. I haven't done extensive testing (so maybe something is broken), but I was able to run the sender/receiver examples from mavlink-routerd

Is future only required for python2?

@bobpaul
Copy link

bobpaul commented Jan 14, 2025

Derp, I can be kinda dumb sometimes. I had the mavlink project checked out (with pymavlink as a submodule) and I was doing git grep from within mavlink instead of in mavlink/pymavlink :-/

Attached is a patch that I think should maintain python2 compatibility without requiring the future module in python 3.11+. I understand sorted(mydict.items()) is a bit slower on python2.7 than using iteritems() from future, but it should still return the same result.

remove_future.patch.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants