Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report update questions - MVZ Bird Narrow box label #8363

Open
dustymc opened this issue Dec 11, 2024 · 5 comments
Open

report update questions - MVZ Bird Narrow box label #8363

dustymc opened this issue Dec 11, 2024 · 5 comments
Labels
function-Reports Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. report: need more information Need help from collection
Milestone
Reporter

Comments

@dustymc
Copy link
Contributor

dustymc commented Dec 11, 2024

https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=180

@mkoo this report pulls "collectornumber" as a cascade of 'if exist then else ...', and then separately "collector_number_issued_by" and "preparator_number_issued_by", with the comment

In the cases where a PLC identifier exists, the preparator number should be listed in the collector slot

Please confirm that these are somehow separate and can't be merged with one function

If I understand the situation, I will experiment with 2 functions

  1. get the most-relevant identifier, and
  2. get the 'preparator'
@dustymc dustymc added this to the Reporter milestone Dec 11, 2024
@mkoo mkoo added Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. function-Reports report: need more information Need help from collection labels Dec 16, 2024
@mkoo
Copy link
Member

mkoo commented Dec 16, 2024

The basic need here (ie most relevant) is the original number which is either getting the identifier type of collector or preparator. So a function makes sense! But I think it can be a single one that checks for collector and preparator nums. There are infrequent occasions where there are both.

@dustymc
Copy link
Contributor Author

dustymc commented Dec 31, 2024

infrequent occasions

Yea, always, and I always struggle there - does a label always have to consider and print every possibility supported by the data structure (in which case we'll all go crazy failing to meet that goal...) or can some simpler pull intended just for a specific use case work well enough? I suppose it's taken me way too long to get there, but I'm becoming a dedicated fan of well-documented instances of the latter.

And on that note, how's https://github.com/ArctosDB/PG_DDL/blob/master/function/label_print/get_original_identifier.sql look?

Example data:


arctosprod@arctos>> select guid,get_original_identifier(collection_object_id) from flat where guid_prefix='MVZ:Herp' limit 100;
      guid       |                  get_original_identifier                  
-----------------+-----------------------------------------------------------
 MVZ:Herp:228966 | Theodore J. Papenfuss collector number 24651
 MVZ:Herp:232168 | David B. Wake collector number 5354-g
 MVZ:Herp:264689 | Javier A. Rodríguez-Robles collector number 2748
 MVZ:Herp:228992 | Theodore J. Papenfuss collector number 24560
 MVZ:Herp:287298 | Wilbur W. Mayhew collector number 114
 MVZ:Herp:254423 | Jimmy A. McGuire collector number JAM 4909
 MVZ:Herp:293231 | Sean B. Reilly collector number SBR 264
 MVZ:Herp:291704 | Jimmy A. McGuire collector number JAM 13634
 MVZ:Herp:84078  | James F. Lynch collector number 1378
 MVZ:Herp:293775 | Jimmy A. McGuire collector number JAM 11484
 MVZ:Herp:292859 | Jimmy A. McGuire collector number JAM 13145
 MVZ:Herp:291698 | Jimmy A. McGuire collector number JAM 13338
 MVZ:Herp:293506 | Jimmy A. McGuire collector number JAM 13437
 MVZ:Herp:215969 | 
 MVZ:Herp:294825 | Jimmy A. McGuire collector number JAM 13505
 MVZ:Herp:263491 | Carlos Roberto Vasquez Almazan collector number CRVA 1197
 MVZ:Herp:252750 | Erica Bree Rosenblum collector number EBR 16
 MVZ:Herp:291739 | Jimmy A. McGuire collector number JAM 13055
 MVZ:Herp:294043 | Jimmy A. McGuire collector number JAM 13912
 MVZ:Herp:90834  | David B. Wake collector number A-556
 MVZ:Herp:90839  | David B. Wake collector number A-561
 MVZ:Herp:41453  | Richard E. Genelly collector number 50
 MVZ:Herp:28293  | Thomas L. Rodgers collector number 2057
 MVZ:Herp:149435 | Paul Elias collector number 607
 MVZ:Herp:263481 | Carlos Roberto Vasquez Almazan collector number CRVA 1182
 MVZ:Herp:263422 | Sean M. Rovito collector number SMR 290
 MVZ:Herp:263482 | Sean M. Rovito collector number SMR 285
 MVZ:Herp:293588 | Jimmy A. McGuire collector number JAM 13182
 MVZ:Herp:149448 | Paul Elias collector number 620
 MVZ:Herp:149454 | Paul Elias collector number 626
 MVZ:Herp:149434 | Paul Elias collector number 606
 MVZ:Herp:287719 | Wilbur W. Mayhew collector number 515
 MVZ:Herp:253297 | Adam D. Leache collector number 3208
 MVZ:Herp:2786   | N. B. Stern collector number 746
 MVZ:Herp:253180 | Adam D. Leache collector number 3210
 MVZ:Herp:273682 | Charles M. Crisafulli collector number MSHA0423
 MVZ:Herp:291596 | Sean B. Reilly collector number SBR 133
 MVZ:Herp:293820 | Jimmy A. McGuire collector number JAM 13034
 MVZ:Herp:287046 | Wilbur W. Mayhew collector number 304
 MVZ:Herp:294655 | Jimmy A. McGuire collector number JAM 12132
 MVZ:Herp:72266  | Joseph La Pointe collector number 22
 MVZ:Herp:72267  | Joseph La Pointe collector number 23
 MVZ:Herp:294087 | Jimmy A. McGuire collector number JAM 13853
 MVZ:Herp:72264  | Joseph La Pointe collector number 20
 MVZ:Herp:41193  | Robert C. Stebbins collector number 187
 MVZ:Herp:27800  | Thomas Paul Maslin collector number 1768
 MVZ:Herp:97897  | David B. Wake collector number A-1505
 MVZ:Herp:14723  | Howard K. Gloyd collector number 816
 MVZ:Herp:120809 | Samuel S. Sweet collector number 9244
 MVZ:Herp:14427  | Seth B. Benson collector number 1838
 MVZ:Herp:265429 | collector number 265
 MVZ:Herp:264684 | Javier A. Rodríguez-Robles collector number JAR 2743
 MVZ:Herp:293508 | Jimmy A. McGuire collector number JAM 13446
 MVZ:Herp:272764 | Sean M. Rovito collector number SMR 2077
 MVZ:Herp:294035 | Jimmy A. McGuire collector number JAM 13453
 MVZ:Herp:211007 | J. Robert Macey collector number 5177
 MVZ:Herp:18749  | Henry S. Fitch collector number 2780
 MVZ:Herp:190953 | Robert W. Hansen collector number 1912
 MVZ:Herp:190959 | Robert W. Hansen collector number 1918
 MVZ:Herp:187528 | E. Kenneth Teberg collector number 1
 MVZ:Herp:79241  | Robert C. Stebbins collector number 10524
 MVZ:Herp:60278  | Sherburne F. Cook Jr. collector number 336
 MVZ:Herp:204249 | David A. Good collector number T-13
 MVZ:Herp:7517   | Halstead G. White collector number 4124
 MVZ:Herp:251076 | Javier A. Rodríguez-Robles collector number 1368
 MVZ:Herp:77066  | Theodore J. Papenfuss collector number 1121
 MVZ:Herp:206138 | David A. Good collector number 2219
 MVZ:Herp:79169  | Robert C. Stebbins collector number 10529
 MVZ:Herp:246066 | Matthew C. Brandley collector number 347
 MVZ:Herp:22974  | J. Linsley Gressitt collector number 634
 MVZ:Herp:63085  | Oliver P. Pearson collector number 3244
 MVZ:Herp:232178 | Theodore J. Papenfuss collector number 26602
 MVZ:Herp:243064 | João M. Alexandrino collector number 93
 MVZ:Herp:288351 | Wilbur W. Mayhew collector number 73
 MVZ:Herp:254246 | BSI Biotic Survey and Inventory identifier BSI 2129
 MVZ:Herp:206132 | David A. Good collector number 2213
 MVZ:Herp:288442 | Wilbur W. Mayhew collector number 347
 MVZ:Herp:29341  | E. Raymond Hall collector number 5628
 MVZ:Herp:14721  | Howard K. Gloyd collector number 814
 MVZ:Herp:74719  | Bruce Bartholomew collector number 90
 MVZ:Herp:14722  | Howard K. Gloyd collector number 815
 MVZ:Herp:185970 | Stanley K. Sessions collector number 2369
 MVZ:Herp:150609 | John E. Cadle collector number 1070
 MVZ:Herp:7512   | Halstead G. White collector number 4119
 MVZ:Herp:7504   | Halstead G. White collector number 4111
 MVZ:Herp:7505   | Halstead G. White collector number 4112
 MVZ:Herp:77068  | Theodore J. Papenfuss collector number 1123
 MVZ:Herp:287212 | Wilbur W. Mayhew collector number 84
 MVZ:Herp:17442  | Henry S. Fitch collector number 2165
 MVZ:Herp:287045 | Wilbur W. Mayhew collector number 303
 MVZ:Herp:70899  | James Donald Anderson collector number 2819
 MVZ:Herp:155420 | Kay P. Yanev collector number 5047
 MVZ:Herp:155409 | Kay P. Yanev collector number 5036
 MVZ:Herp:84601  | Alexander K. Johnson collector number 307
 MVZ:Herp:76814  | Charles W. Brown collector number 472
 MVZ:Herp:155419 | Kay P. Yanev collector number 5046
 MVZ:Herp:190954 | Robert W. Hansen collector number 1913
 MVZ:Herp:177109 | Robert L. Seib collector number 9153
 MVZ:Herp:254421 | Jimmy A. McGuire collector number JAM 4883
 MVZ:Herp:59901  | Keith F. Murray collector number 979

@cjconroy
Copy link

cjconroy commented Jan 2, 2025

I'm following this thread. I noticed above someone wrote that "where a PLC identifier exists, the preparator number should be listed in the collector slot". PLC numbers are not preparator numbers, they are identifiers issued by the MVZ PLC.

@dustymc
Copy link
Contributor Author

dustymc commented Jan 2, 2025

@cjconroy an example record and the desired 'original_identifier' from it would be useful so that I can tune the function to get that. (Or tell me where I got lost, I don't really understand this complexity and might be completely on the wrong track...)

@cjconroy
Copy link

cjconroy commented Jan 2, 2025

I'll let the bird folks respond about bird labels. I just sent an email to the mammal curators to see what their preference is regarding names and numbers. We used to use parentheses around preparator names and numbers, but we also included both names when we did labels by hand. I doubt there is going to be room for all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
function-Reports Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. report: need more information Need help from collection
Projects
None yet
Milestone
Reporter
Development

No branches or pull requests
3 participants
@mkoo @dustymc @cjconroy