Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evolved to: Help needed w/ SQL for MSB:Mamm Loan Invoice Zoo html report #8358

Open
campmlc opened this issue Dec 7, 2024 · 10 comments
Open
Assignees
Labels
function-Reports Priority-High (Needed for work) High because this is causing a delay in important collection work..
Milestone

Comments

@campmlc
Copy link

campmlc commented Dec 7, 2024

Tell us what you are trying to do

MSB loan invoice reports have this error message:
"This report must be rewritten with separated SQL.
Reports with inline SQL will be disabled in the near future.
File an Issue for help."

I'm filing the issue for help.
For example: https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=96
But it looks like all the loan invoice detail templates in html?

@campmlc campmlc added Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. function-Reports labels Dec 7, 2024
@mkoo
Copy link
Member

mkoo commented Dec 7, 2024

FYI you can still use (ie print) these reports as the red box is just a nag to update to the new separation of SQL.
I can edit for you but would rather Dusty review systematically since it's on his to-do list.

Unless you need to edit the report? If so let us know

@campmlc
Copy link
Author

campmlc commented Dec 7, 2024

That's fine - I just didn't want them to cease working.

@mkoo
Copy link
Member

mkoo commented Dec 7, 2024

Question addressed!

@mkoo mkoo closed this as completed Dec 7, 2024
@campmlc campmlc reopened this Dec 16, 2024
@campmlc campmlc added Priority-High (Needed for work) High because this is causing a delay in important collection work.. and removed Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. labels Dec 16, 2024
@campmlc
Copy link
Author

campmlc commented Dec 16, 2024

Reopening - all MSB Loan Invoice reports are now non-functional and marked with a skull and crossbones in the Arctos reporter. I really need these reports to be working today, actually this morning, in order to ship. @mkoo @dustymc

Screenshot 2024-12-16 11 42 28

@mkoo
Copy link
Member

mkoo commented Dec 16, 2024

Go ahead and print-- that's just whether the SQL has been reviewed and migrated to its more secure spot-- shouldnt impact printing if the report is good.
Let us know if there's a specific report and SQL that needs attention

note for future: use less dramatic iconography!

@campmlc
Copy link
Author

campmlc commented Dec 16, 2024

Yes, printing still works, thanks. Agree with changing the iconography to something less permanently dead.

As for other reports, I could use help with this one: MSB:Mamm Loan Invoice Zoo html

@mkoo
Copy link
Member

mkoo commented Dec 16, 2024

Can you tell us what you need specifically changed with that invoice? (I assume it's https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=111)

@campmlc
Copy link
Author

campmlc commented Dec 16, 2024

I'm not sure, because all I get is an error message?

@mkoo
Copy link
Member

mkoo commented Dec 16, 2024

ok, @dustymc when you can, please check out the SQL for https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=111

There's a lot of extraneous stuff being selected for and none of them seem to be in use in the HTML but the main errors are 'cannot find' sort of things ( at least 3) and I dont know my way around transaction stuff as much as just vanilla flat searches

Go ahead and prioritize over the MVZ ones-thx!

@mkoo mkoo changed the title Help needed in Arctos for MSB Loan Invoice SQL evolved to: Help needed w/ SQL for MSB:Mamm Loan Invoice Zoo html report Dec 16, 2024
@mkoo mkoo assigned dustymc and unassigned mkoo and campmlc Dec 16, 2024
@dustymc dustymc added this to the Reporter milestone Dec 17, 2024
@dustymc
Copy link
Contributor

dustymc commented Dec 17, 2024

check out the SQL for https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=111
stuff being selected

  1. I need example data, an exemplary loan should be appropriate in this case
  2. I need to know specifically what information is needed. I can accept that in about any format, but examples tend to be most effective. Maybe print/PDF/screenshot some form/forms and circle/highlight/whatever what you want from it/them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
function-Reports Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

3 participants