-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfaults during CDX read #24
base: v1.21.3-at
Are you sure you want to change the base?
Conversation
This writes invalid WARC-Refers-To-Date headers--oops. This is because the code would now read the timestamps from the CDX file (which appears to be formatted as I can have the code rewrite the CDX timestamp into the UTC timestamp according to the W3CDTF, but I am slightly hesitant to (unless given the okay) since I don't know if all properly formed CDX files will have their timestamps be in the form of |
98d7eb6
to
463b2f6
Compare
The invalid WARC-Refers-To-Date headers issue should be fixed now |
Thank you! It looks like I will need to check this PR closer before merging it. |
Oopsie (and you're welcome!) |
If this is not done, wget segfaults if --warc-dedup is not passed (but --warc-file and --warc-cdx is)
Fixes #23