Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: allow evm_version to be set per network [APE-1045] #86

Open
bout3fiddy opened this issue Jun 9, 2023 · 2 comments
Open

Comments

@bout3fiddy
Copy link

Overview

in ape-config.yaml, allow user to do:

vyper:
    evm_version: shanghai
    arbitrum:
         evm_version: paris
@vany365 vany365 changed the title set evm version in config set evm version in config [APE-1045] Jun 9, 2023
@bout3fiddy bout3fiddy changed the title set evm version in config [APE-1045] feature request: set evm version in config [APE-1045] Jun 9, 2023
@antazoey
Copy link
Member

antazoey commented Jun 19, 2023

the first part of this already should work:

vyper:
  evm_version: shanghai

let me know if it doesnt but it was added here: b75ee5d

the second part is a valid refactor request though, however it may look like:

vyper:
  # evm_version: this works but will set it for all ecosystems
  ethereum:
    mainnet:
      evm_version: shanghai
  arbitrum:
    mainnet:
      evm_version: paris

@antazoey antazoey changed the title feature request: set evm version in config [APE-1045] feature request: allow evm_version to be set per network [APE-1045] Jun 19, 2023
@antazoey
Copy link
Member

when using the ecosystem approach, we'd have to cache artifacts accordingly and for each custom settings (because technically you can compile w/o being connected anywhere..

this might take more thought but i can see why this is much needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants