Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] - Move season GUIDs out of main.py to allow easy future adjustment each season without recompiling #16

Open
bbeenn1 opened this issue Nov 7, 2022 · 1 comment
Open

[Proposal] - Move season GUIDs out of main.py to allow easy future adjustment each season without recompiling #16

bbeenn1 opened this issue Nov 7, 2022 · 1 comment
Labels
Status: Pending Attention is needed, issue hasn't been addressed Type: Enhancement New feature or request

Comments

@bbeenn1
Copy link
Contributor

bbeenn1 commented Nov 7, 2022

Likely simple solution:
Add season guids to guids.json
Will require some re-coding of main.py to load them correctly most likely.

Alternatively create another json to load them from such as season_guids.json.
This would lead to the ability to create another cosmetics_guids.json as well if that is planned.
@bbeenn1 bbeenn1 added the Type: Enhancement New feature or request label Nov 7, 2022
@AnthonyMichaelTDM
Copy link
Owner

I completely agree, I'm planning on refactoring the entire code base to follow SOLID design principles but I'm really busy with college right now.

@AnthonyMichaelTDM AnthonyMichaelTDM added the Status: Pending Attention is needed, issue hasn't been addressed label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Attention is needed, issue hasn't been addressed Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbeenn1 @AnthonyMichaelTDM