Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse Reference Only Copy Feature #1387

Closed
Dleemuse opened this issue Jul 23, 2021 · 12 comments · May be fixed by #2178
Closed

Verse Reference Only Copy Feature #1387

Dleemuse opened this issue Jul 23, 2021 · 12 comments · May be fixed by #2178

Comments

@Dleemuse
Copy link

When copying a verse(s) is it possible to have a feature where only the reference is copied? I have often, wanted to be able to copy just the reference(s) and not the verse(s) themselves.

Thanks!

Deba

@gelafin
Copy link
Contributor

gelafin commented May 1, 2022

Would a good implementation just add a "Reference only" option at the bottom of this list of sharing options?
Screenshot_20220430-175307_Bible Study

@agrogers
Copy link
Contributor

agrogers commented May 1, 2022

That dialog has a lot more options now. But it needs a reference only option as well. I think I would put it at the top and when selected disables or hides most of the other options.

Screenshot_2022-05-01-09-03-17-073_net.bible.android.activity.jpg

@agrogers
Copy link
Contributor

agrogers commented May 1, 2022

Maybe 'Show reference only' should be the first indented option.

@gelafin
Copy link
Contributor

gelafin commented May 1, 2022

I see, thanks! Agree that would be a good place for it.

I'll check the development version next time :)

@agrogers
Copy link
Contributor

agrogers commented May 2, 2022 via email

@gelafin
Copy link
Contributor

gelafin commented May 3, 2022

Interesting, the Play store shows I'm a beta tester, but my version of the app is 4.0.643#fa0aa5137 standard release. Fine for me to just reference my emulated version in Android Studio, though!

@tuomas2
Copy link
Contributor

tuomas2 commented May 5, 2022

It is in develop branch, but we have not released any beta builds yet in Play Store yet. Alpha builds are available for develop brach (version numbers still match with production ones to make switching back and forth easy, and is possible because we do not have yet any migrations in develop): https://github.com/AndBible/and-bible/releases.

@gelafin
Copy link
Contributor

gelafin commented May 19, 2022

@agrogers On second thought, would this layout be good for these options?

  • Show reference
    • Abbreviate
    • With Bible version
    • At front
  • Show verse text
    • Only selected text
      • With ellipsis (...)
    • With verse numbers
    • With quotes
  • Advertise app

That would making showing and hiding verse text work the same as for the reference and advertisement.

@agrogers
Copy link
Contributor

agrogers commented Jun 10, 2022

I have created a draft pull request for this. You can see it here:
#2178

The change is minor and simply hides the text of the verse. Let me know if you have any extra suggestions.

image

image

@gelafin
Copy link
Contributor

gelafin commented Jun 14, 2022

awesome, looks great!

@tuomas2 tuomas2 moved this to Earliest 4.1+ in Tuomas' project board Sep 7, 2022
@agrogers
Copy link
Contributor

agrogers commented Oct 11, 2022 via email

@agrogers
Copy link
Contributor

this has been done now I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants