Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insertion marker in study pad #1694

Open
timbze opened this issue Sep 11, 2021 · 6 comments
Open

Insertion marker in study pad #1694

timbze opened this issue Sep 11, 2021 · 6 comments
Labels
Sponsor me! Please send message if you like to sponsor this feature https://shop.tuomasairaksinen.fi/contact Type: Feature

Comments

@timbze
Copy link
Contributor

timbze commented Sep 11, 2021

When I have a study pad with notes and verses, I often find that I would like to insert some bookmark verses in the middle somewhere and sometimes indented.

I think it would be a nice feature to have a visible insertion marker that I could move, that would mark where the next bookmarked verse would insert. The marker could be moved anywhere between verses or notes and could be indented

@tuomas2
Copy link
Contributor

tuomas2 commented Sep 11, 2021

I already started working on this (there's draft pr), but found out that it's something that one need to be extra careful and requires making tests etc, so it's not trivial to implement. And then I have found that 99% cases need to add bookmarks is to the end of studypad. So I think this falls into category of "good to have", but not essential.

@tuomas2
Copy link
Contributor

tuomas2 commented Sep 11, 2021

@timbze
Copy link
Contributor Author

timbze commented Sep 11, 2021

I think the 99% might be correct when you're listening to a sermon, but I also use it for studying and there for me it's maybe closer to 50% 😊

I didn't know what that PR was about. Sounds good.

@tuomas2
Copy link
Contributor

tuomas2 commented Sep 16, 2021

I believe this is doable without new strings so if we get this done we can include in 4.0+

@agrogers
Copy link
Contributor

agrogers commented Sep 16, 2021 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Sep 16, 2021

We can add some small features that do not add new strings and don't confuse users in 4.0+ releases.

That's my plan, though it's debatable if there are opinions.

@tuomas2 tuomas2 moved this to Earliest 4.0+ in Tuomas' project board Sep 7, 2022
@tuomas2 tuomas2 added the Sponsor me! Please send message if you like to sponsor this feature https://shop.tuomasairaksinen.fi/contact label Aug 26, 2023
@github-project-automation github-project-automation bot moved this to Triage needed in Wishing Well Aug 26, 2023
@tuomas2 tuomas2 removed this from Wishing Well Oct 14, 2023
@tuomas2 tuomas2 moved this from Needs triage to Shortish term planned features in Tuomas' project board Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsor me! Please send message if you like to sponsor this feature https://shop.tuomasairaksinen.fi/contact Type: Feature
Projects
Status: Prio 4 (Feats)
Development

No branches or pull requests

3 participants