From 25cdf32460670648af2722da2c5176ed04b397ae Mon Sep 17 00:00:00 2001 From: Jahlia Finney Date: Fri, 22 Feb 2019 14:01:18 -0500 Subject: [PATCH 01/15] made some corrections --- assessment.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/assessment.md b/assessment.md index 5844937..02b3c31 100644 --- a/assessment.md +++ b/assessment.md @@ -105,7 +105,7 @@ when creating python programs. * N = No written code or monolithic code * I = Language constructs used inappropriately * A = Some language constructs used appropriately - * G = Most language constructs used efficiently + * G = Most language constructs used appropriately * E = All language constructs used efficiently and reason is documented ### Project Management with GitHub @@ -119,13 +119,14 @@ when creating python programs. * E = Issue is unique, well described, and a possible reason for occurrence and solution is mentioned * Using the GitHub flow model - * N = GitHub flow model unused or no commits - * I = Pushed to master or non-descriptive commits - * A = Pushed to correct repository with descriptive commits + * N = GitHub flow model unused or no commits to the Github repository + * I = Pushed to master or non-descriptive commits to the Github repository + * A = Pushed to correct repository with descriptive commits to the Github + repository * G = Use of a branch/fork demonstrated appropriately (e.g having a feature branch) along with descriptive commits * E = Use of multiple useful branches/forks demonstrated appropriately - containing multiple coherent and descriptive commits + containing multiple consistent and descriptive commits * Creating and using a repository branch * N = Did not create or utilize branches * I = Create unclear branches From 0b543bd203f2a1a888c64095d1d5fff35227b66e Mon Sep 17 00:00:00 2001 From: Jahlia Finney Date: Fri, 22 Feb 2019 14:17:46 -0500 Subject: [PATCH 02/15] made some more corrections --- assessment.md | 41 ++++++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/assessment.md b/assessment.md index 02b3c31..219dada 100644 --- a/assessment.md +++ b/assessment.md @@ -129,23 +129,23 @@ when creating python programs. containing multiple consistent and descriptive commits * Creating and using a repository branch * N = Did not create or utilize branches - * I = Create unclear branches - * A = Create too many poorly named branches - * G = Create useful adequately named branches - * E = Create useful and descriptive branches + * I = Created unclear branches + * A = Created too many poorly named branches + * G = Created useful adequately named branches + * E = Created useful and descriptive branches * Creating and using a repository fork * N = Did not create or utilize forks - * I = Create unclear forks - * A = Create too many poorly named forks - * G = Create useful adequately named forks - * E = Create useful and descriptive forks + * I = Created unclear forks + * A = Created too many poorly named forks + * G = Created useful adequately named forks + * E = Created useful and descriptive forks * Merging a branch or a fork to another branch or fork * N = Not communicating changes before merging branches and forks - * I = Merging with minimal communication or merging faulty code + * I = Merging with minimal communication or merging defective code * A = Communicating changes with the team and reconciling differences * G = Merging branches after extensive communication * E = Merging branches with well-documented, detailed code and - extensive communication + extensive team communication * Creating and reviewing a pull request * N = No PR made * I = Does not tag the related issues it is trying to close with poor description @@ -156,11 +156,11 @@ when creating python programs. * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages - * N = Commit messages are nonsensical + * N = Commit messages do not make sense * I = Commit messages are uninformative * A = Commit messages are sensible but not descriptive - * G = Commit messages are both clear, and moderately descriptive - * E = Commit messages are clear, concise and descriptive + * G = Commit messages are clear, concise and moderately descriptive + * E = Commit messages are clear, concise, and descriptive ### Continuous Integration with Travis @@ -203,30 +203,33 @@ when creating python programs. * A = A few status badges are in the README but are not in an appropriate location * G = Most relevant status badges are in the README and well located - * E = All relevant and many useful status badges are in the README and well located + * E = All relevant and many useful status badges are in the README and well + located ### Foundations of Software Engineering * Requirements engineering - * N = No effort to document, define, or maintain requirements present + * N = No effort to document, define, or maintain requirements present is + evident * I = Brief or unspecific documentation, definition, and maintenance given * A = Explains what requirements have been specified in enough detail to convey the most important information - * G = Documentation and definitions are well written and gives other team members + * G = Documentation and definitions are well written giving other team members an informed idea of the process - * E = The software engineer displayed highly detailed, elaborate, and complete + * E = Displayed highly detailed, elaborate, and complete documentation, definition, and maintenance in the given design process * Software architecture * N = There is no consideration to the structure or organization of the project * I = There are small amounts of structure to the system - * A = There is a blueprint for the software system that lacks completion + * A = There is a blueprint for the software system that is not complete * G = There is a completed blueprint for the software system * E = There is a completed detailed blueprint for all elements of the software system including detailed documentation * Software design * N = No attempt to create a design * I = Initial steps are taken to conceptualize, frame, and implement systems - * A = Some software design is visible to the point where a software solution looks + * A = Some software design is visible to the point where a software solution + looks to be developed soon * G = A software solution is created that includes both an algorithm design and a high-level architecture design From ad3eafc18259b9c5c7ae4d65c9f5c36dc4a833c0 Mon Sep 17 00:00:00 2001 From: Jahlia Finney Date: Fri, 22 Feb 2019 14:23:30 -0500 Subject: [PATCH 03/15] fixed third party --- assessment.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/assessment.md b/assessment.md index 219dada..3e81421 100644 --- a/assessment.md +++ b/assessment.md @@ -183,10 +183,10 @@ when creating python programs. and signed deliverables (e.g md5 hash) * Create third-party integrations with Travis CI (e.g., codecov.io) * N = No incorporation of third party integrations - * I = Third party integrations were only partially implemented - * A = A few third party integrations were implemented - * G = Most third party integrations were implemented - * E = Many useful and relevant third party integrations were implemented + * I = Third-party integrations were only partially implemented + * A = A few third-party integrations were implemented + * G = Most third-party integrations were implemented + * E = Many useful and relevant third-party integrations were implemented * Add README badges that show status of Travis CI builds * N = No addition of badges to the README * I = Badge added for Travis CI builds but does not work From 31d73f22cdebdb4bd08ff87b430c7cc91261f1bf Mon Sep 17 00:00:00 2001 From: Jahlia Finney Date: Fri, 22 Feb 2019 14:25:01 -0500 Subject: [PATCH 04/15] made more corrections --- assessment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assessment.md b/assessment.md index 3e81421..720d7c1 100644 --- a/assessment.md +++ b/assessment.md @@ -169,7 +169,7 @@ when creating python programs. * I = Sets up and configures Travis CI which performs no checks * A = Sets up and configures Travis CI without performing checks on less relevant project deliverables - * G = Sets up and configures Travis CI to perform checks on most relevant + * G = Sets up and configures Travis CI to perform checks on the most relevant project deliverables * E = Correctly sets up and configures Travis CI to perform relevant checks for all project deliverables From 9701f4e858d448eb8e15ea187f64a86bd95f8f42 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 18:00:10 -0500 Subject: [PATCH 05/15] add link --- assessment.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/assessment.md b/assessment.md index 720d7c1..1fb6d1d 100644 --- a/assessment.md +++ b/assessment.md @@ -147,12 +147,12 @@ when creating python programs. * E = Merging branches with well-documented, detailed code and extensive team communication * Creating and reviewing a pull request - * N = No PR made + * N = No PR(Pull Request) made * I = Does not tag the related issues it is trying to close with poor description * A = Tags any related issues it is trying to close, describes proposed changes by a person * G = Tags any related issues it is trying to close, describes most proposed changes, - discusses results of PR with Travis CI + discusses results of PR with CI * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages @@ -167,7 +167,7 @@ when creating python programs. * Setup and configure Travis CI * N = Fails to perform any setup and configuration of Travis CI * I = Sets up and configures Travis CI which performs no checks - * A = Sets up and configures Travis CI without performing checks on less + * A = Sets up and configures Travis CI that performs checks on less relevant project deliverables * G = Sets up and configures Travis CI to perform checks on the most relevant project deliverables @@ -181,7 +181,7 @@ when creating python programs. * G = Performs a release through Travis CI with signed commits * E = Performs a release through Travis CI with signed commits and signed deliverables (e.g md5 hash) -* Create third-party integrations with Travis CI (e.g., codecov.io) +* Create third-party integrations with Travis CI (e.g., [codecov.io]) * N = No incorporation of third party integrations * I = Third-party integrations were only partially implemented * A = A few third-party integrations were implemented From ae5d40eb277e7d559b63d39d9124122d1e79a09b Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 18:03:08 -0500 Subject: [PATCH 06/15] added link correctly this time --- assessment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assessment.md b/assessment.md index 1fb6d1d..e845603 100644 --- a/assessment.md +++ b/assessment.md @@ -181,7 +181,7 @@ when creating python programs. * G = Performs a release through Travis CI with signed commits * E = Performs a release through Travis CI with signed commits and signed deliverables (e.g md5 hash) -* Create third-party integrations with Travis CI (e.g., [codecov.io]) +* Create third-party integrations with Travis CI (e.g., [codecov](codecov.io)) * N = No incorporation of third party integrations * I = Third-party integrations were only partially implemented * A = A few third-party integrations were implemented From 8ded39b46b94933718c76aa9a0fa31c6f3e46afc Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 18:25:34 -0500 Subject: [PATCH 07/15] changed portion of pull request, may change again --- assessment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assessment.md b/assessment.md index e845603..2dd0089 100644 --- a/assessment.md +++ b/assessment.md @@ -152,7 +152,7 @@ when creating python programs. * A = Tags any related issues it is trying to close, describes proposed changes by a person * G = Tags any related issues it is trying to close, describes most proposed changes, - discusses results of PR with CI + may not pass Travis * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages @@ -181,7 +181,7 @@ when creating python programs. * G = Performs a release through Travis CI with signed commits * E = Performs a release through Travis CI with signed commits and signed deliverables (e.g md5 hash) -* Create third-party integrations with Travis CI (e.g., [codecov](codecov.io)) +* Create third-party integrations with Travis CI (e.g., [codecov](codecov.io) * N = No incorporation of third party integrations * I = Third-party integrations were only partially implemented * A = A few third-party integrations were implemented From 2ab0a16b5c018961604cdc89ea5964a2506e69cb Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 18:35:12 -0500 Subject: [PATCH 08/15] changed portion of pull request -G, again --- assessment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assessment.md b/assessment.md index 2dd0089..d6842f9 100644 --- a/assessment.md +++ b/assessment.md @@ -152,7 +152,7 @@ when creating python programs. * A = Tags any related issues it is trying to close, describes proposed changes by a person * G = Tags any related issues it is trying to close, describes most proposed changes, - may not pass Travis + discusses them with team but may not pass Travis * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages From fb08204f16d7624365f93f9854219a552054e5de Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 18:59:34 -0500 Subject: [PATCH 09/15] fixed pull request for hopefully the final time --- assessment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assessment.md b/assessment.md index d6842f9..5bd31f1 100644 --- a/assessment.md +++ b/assessment.md @@ -151,8 +151,8 @@ when creating python programs. * I = Does not tag the related issues it is trying to close with poor description * A = Tags any related issues it is trying to close, describes proposed changes by a person - * G = Tags any related issues it is trying to close, describes most proposed changes, - discusses them with team but may not pass Travis + * G = Tags any related issues it is trying to close, describes most proposed +changes and passes Travis CI * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages From c63349cec54bf7a0a61b8971e18929c8b51d48c3 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 22 Feb 2019 19:07:11 -0500 Subject: [PATCH 10/15] trying to fix spacing for travis --- assessment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assessment.md b/assessment.md index 5bd31f1..561a805 100644 --- a/assessment.md +++ b/assessment.md @@ -151,8 +151,8 @@ when creating python programs. * I = Does not tag the related issues it is trying to close with poor description * A = Tags any related issues it is trying to close, describes proposed changes by a person - * G = Tags any related issues it is trying to close, describes most proposed -changes and passes Travis CI + * G = Tags any related issues it is trying to close, describes most proposed changes, + and passes Travis CI * E = Tags any related issues it is trying to close, fully describes all proposed changes and passes Travis CI * Using appropriate commit messages From 686003ed18c60e766e17116969ccc23e36d00474 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 26 Feb 2019 22:56:55 -0500 Subject: [PATCH 11/15] fixed formatting and parentheses --- assessment.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/assessment.md b/assessment.md index 561a805..37b849a 100644 --- a/assessment.md +++ b/assessment.md @@ -181,7 +181,7 @@ when creating python programs. * G = Performs a release through Travis CI with signed commits * E = Performs a release through Travis CI with signed commits and signed deliverables (e.g md5 hash) -* Create third-party integrations with Travis CI (e.g., [codecov](codecov.io) +* Create third-party integrations with Travis CI (e.g., [codecov](codecov.io)) * N = No incorporation of third party integrations * I = Third-party integrations were only partially implemented * A = A few third-party integrations were implemented @@ -229,8 +229,7 @@ when creating python programs. * N = No attempt to create a design * I = Initial steps are taken to conceptualize, frame, and implement systems * A = Some software design is visible to the point where a software solution - looks - to be developed soon + looks to be developed soon * G = A software solution is created that includes both an algorithm design and a high-level architecture design * E = All goals and expectations of the design are met and compatibility, reliability, From 518385e87c904088b9c34cc1b1582a6e4337c447 Mon Sep 17 00:00:00 2001 From: Lancaster Wu Date: Sun, 3 Mar 2019 22:18:10 -0500 Subject: [PATCH 12/15] Fixed `made to the GitHub repository` --- assessment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assessment.md b/assessment.md index 37b849a..03ee638 100644 --- a/assessment.md +++ b/assessment.md @@ -119,8 +119,8 @@ when creating python programs. * E = Issue is unique, well described, and a possible reason for occurrence and solution is mentioned * Using the GitHub flow model - * N = GitHub flow model unused or no commits to the Github repository - * I = Pushed to master or non-descriptive commits to the Github repository + * N = GitHub flow model unused or no commits made to the GitHub repository + * I = Pushed to master or non-descriptive commits made to the GitHub repository * A = Pushed to correct repository with descriptive commits to the Github repository * G = Use of a branch/fork demonstrated appropriately From a8cb605036580eb5dbfcfc9bd05d35cc4c5788d0 Mon Sep 17 00:00:00 2001 From: Lancaster Wu Date: Sun, 3 Mar 2019 22:21:37 -0500 Subject: [PATCH 13/15] Fixed request repeat use of `GitHub repo` --- assessment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assessment.md b/assessment.md index 03ee638..353b881 100644 --- a/assessment.md +++ b/assessment.md @@ -119,8 +119,8 @@ when creating python programs. * E = Issue is unique, well described, and a possible reason for occurrence and solution is mentioned * Using the GitHub flow model - * N = GitHub flow model unused or no commits made to the GitHub repository - * I = Pushed to master or non-descriptive commits made to the GitHub repository + * N = GitHub flow model unused or no commits made to the GitHub + * I = Pushed to master or made non-descriptive commits * A = Pushed to correct repository with descriptive commits to the Github repository * G = Use of a branch/fork demonstrated appropriately From 4446301095f9e2060faba5bab2821006d0cd6e9b Mon Sep 17 00:00:00 2001 From: Lancaster Wu Date: Sun, 3 Mar 2019 22:28:53 -0500 Subject: [PATCH 14/15] Fixed requested `or PR` --- assessment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assessment.md b/assessment.md index 353b881..aad35a2 100644 --- a/assessment.md +++ b/assessment.md @@ -147,7 +147,7 @@ when creating python programs. * E = Merging branches with well-documented, detailed code and extensive team communication * Creating and reviewing a pull request - * N = No PR(Pull Request) made + * N = No PR or Pull Request made * I = Does not tag the related issues it is trying to close with poor description * A = Tags any related issues it is trying to close, describes proposed changes by a person From f0d7ce767e90d510e49d54b2b53ffaffc862e249 Mon Sep 17 00:00:00 2001 From: Lancaster Wu Date: Sun, 3 Mar 2019 22:31:54 -0500 Subject: [PATCH 15/15] Fixed requested "incomplete" --- assessment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assessment.md b/assessment.md index aad35a2..3c2b71b 100644 --- a/assessment.md +++ b/assessment.md @@ -221,7 +221,7 @@ when creating python programs. * Software architecture * N = There is no consideration to the structure or organization of the project * I = There are small amounts of structure to the system - * A = There is a blueprint for the software system that is not complete + * A = There is a incomplete blueprint for the software system * G = There is a completed blueprint for the software system * E = There is a completed detailed blueprint for all elements of the software system including detailed documentation