Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Z bias of TRD-matched tracks #12872

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

shahor02
Copy link
Collaborator

  1. When the time bias of TPC timebins was introduced, it had to be explicitly accounted for in the TPC tracks refits constrained by TRD timestamps (the t0 was subtracted from the TRD time). When the TPC fitter started to account for this t0 bias provided via VDrift object, this explicit accounting had to be removed but it was not. As a result, the t0 bias was accounted for twice, leading to a few cm bias in Z for constrained TPC tracks. While we were using large (1cm) systematic errors on Z error of TPC tracks, this bias was overridden by the following refit in the TRD or in the ITS, once we adopted smaller Z-error the bias started to affect matching in the TOF.

  2. The TPC refitter was called on the track at the outer ITS or inner TRD radius (for the outward and inward refits resp.). Since the refitter propagates w/o material corrections, effectively the tracks were not accounting for the material between the TPC and ITS/TRD (before the refit, so the effect was small anyway). Now the tracks are explicitly propagated before the refit to the TPC boundary using the standard propagator accounting for materials.

Comparison of Z residuals between TOF clusters and seeding tracks before and after the fix:
tofbias

1) When the time bias of TPC timebins was introduced, it had to be explicitly accounted for in the TPC tracks refits constrained by TRD timestamps (the t0 was subtracted from the TRD time).
When the TPC fitter started to account for this t0 bias provided via VDrift object, this explicit accounting had to be removed but it was not.
As a result, the t0 bias was accounted for twice, leading to a few cm bias in Z for constrained TPC tracks.
While we were using large (1cm) systematic errors on Z error of TPC tracks, this bias was overridden by the following refit in the TRD or in the ITS,
once we adopted smaller Z-error the bias started to affect matching in the TOF.

2) The TPC refitter was called on the track at the outer ITS or inner TRD radius (for the outward and inward refits resp.). Since the refitter propagates w/o material corrections,
effectively the tracks were not accounting for the material between the TPC and ITS/TRD (before the refit, so the effect was small anyway).
Now the tracks are explicitly propagated befor the refit to the TPC boundary using the standard propagator accounting for materials.
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

Copy link
Contributor

@martenole martenole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shahor02 and sorry. I was not aware of this.

@shahor02
Copy link
Collaborator Author

(1) was done by me :)

@noferini
Copy link
Collaborator

Hi @shahor02 , can we merge this PR?

@shahor02 shahor02 merged commit 0491dd6 into AliceO2Group:dev Mar 15, 2024
14 checks passed
@shahor02 shahor02 deleted the pr_fixTRD branch March 15, 2024 16:17
@chiarazampolli
Copy link
Collaborator

Hi @shahor02 ,

Thanks for the fix. I have a doubt: you wrote that the t0 was applied 2x to constrained TPC tracks, which would include ITSTPC. But these did not show issue in the TOF matching. Could you please explain me a bit better?

Thanks,

Chiara

@shahor02
Copy link
Collaborator Author

Hi @chiarazampolli

The double counting was only for the refits done in the TRD matcher, other refits were ok. TRD matcher re-constrains only ITS-TPC and TPC tracks before the for in the TRD. Both were affected, TPC-only having larger errors is then partially corrected by the TRD fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants