Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Continue porting CUDA features to HIP: Main class files are now fully aligned. #12864

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

davidrohr
Copy link
Collaborator

Doesn't mean that all features are already working in HIP, but the normal tracking remains working, and we can now start to generate the HIP files from the CUDA files.

@davidrohr davidrohr requested a review from a team as a code owner March 14, 2024 09:56
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 0c9a9f7 at 2024-03-14 12:47:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Full log here.

Was wrong for a long time, but not spotted since return value was not checked before
@davidrohr davidrohr merged commit b316ab5 into AliceO2Group:dev Mar 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants