Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand MCTrack to contain proper energy property #11884

Closed
wants to merge 2 commits into from

Conversation

sawenzel
Copy link
Collaborator

Adding energy component to MCTrack properties.

Needs to be done since AOD also has energy
and we need to store generator particles for which we don't know the mass (strings, resonances).

Despite adding an energy property to MCTrack,
we still use a hybrid mode:

a) for primaries, and few secondaries, we store the energy proper

b) for most secondaries, we store -1 in order
and still use the mass from the TPDGDatabase to calculate the energy.
This will ensure large compression and an almost zero impact on disc file size.
We can do this since secondaries have a well defined mass.

In result, the energy of MC particles in AOD should now be completely trustable.

@sawenzel sawenzel requested review from benedikt-voelkel and a team as code owners September 11, 2023 14:22
Adding energy component to MCTrack properties.

Needs to be done since AOD also has energy
and we need to store generator particles for which
we don't know the mass (strings, resonances).

Despite adding an energy property to MCTrack,
we still use a hybrid mode:

a) for primaries, and few secondaries, we store the energy proper

b) for most secondaries, we store -1 in order
   and still use the mass from the TPDGDatabase to calculate the energy.
   This will ensure large compression and an almost zero impact on disc file size.
   We can do this since secondaries have a well defined mass.

In result, the energy of MC particles in AOD should now be completely trustable.
Adding more ions (learned from G4 simulation).

This makes sure that the table used from AOD is the same
as the the table constructed during G4 simulation (or at least
more consistent).
@sawenzel sawenzel force-pushed the swenzel/MCTrackEnergy branch from 7120550 to d7ff247 Compare September 13, 2023 14:31
@alibuild
Copy link
Collaborator

alibuild commented Sep 13, 2023

Error while checking build/O2/fullCI for d7ff247 at 2024-03-18 11:33:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log
sim.log-[10:33:28][FATAL] Inconsistency in primary particles treated 96 vs expected 97
[ERROR] SHUTTING DOWN DUE TO SIGNALED EXIT IN COMPONENT 4674
[10:33:28][FATAL] Inconsistency in primary particles treated 96 vs expected 97


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/ecfbcbbb689b1ad5f3a977689a6e26eb1f3b2b5f/slc8_x86-64/o2checkcode/1.0-local2267/etc/modulefiles
++ cat
--

Full log here.

Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Apr 18, 2024
@github-actions github-actions bot closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants