Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giphy plugin causes slow image loading due to not using limit query parameter #1436

Open
synth opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1437
Open

Giphy plugin causes slow image loading due to not using limit query parameter #1436

synth opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1437

Comments

@synth
Copy link

synth commented Dec 15, 2023

Currently, the Giphy plugin does not include limit query parameter and can result in a really slow response from Giphy. I have seen this be upwards of 20s response time before images will load.

In my testing, simply adding a limit parameter to something like 50 will result in sub 1s response times.

This can be worked around by adding limit to the "rating" plugin option, but this is hacky. This plugin should support all the options that Giphy has to be future proof:

image

UPDATE: I originally thought just limit was the issue. In actuality it was more about the "renditions" used when the picker loads lots of gifs at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant