Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more efficient Base64 Encoder/Decoder #81

Open
1 task
mdedetrich opened this issue Jan 13, 2022 · 0 comments
Open
1 task

Use a more efficient Base64 Encoder/Decoder #81

mdedetrich opened this issue Jan 13, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 13, 2022

What is currently missing?

Currently we are using Java's basic java.util.Base64 encoder/decoder to transform the byte arrays into Base64, we should explore faster/more efficient options

The streaming here is also applicable since the payloads for kafka messages can potentially be quite large

How could this be improved?

There already appears to be a highly performant solution used by akka-http at https://github.com/akka/akka-http/blob/main/akka-parsing/src/main/java/akka/parboiled2/util/Base64.java

Note that akka-http is already available in guardian as a transitive dependency so no dependencies need to be added.

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@mdedetrich mdedetrich added the good first issue Good for newcomers label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant