Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check returncode before assuming task has failed because stderr is non-empty #62

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Check returncode before assuming task has failed because stderr is non-empty #62

wants to merge 2 commits into from

Conversation

araghukas
Copy link
Contributor

  • I have added the tests to cover my changes.
  • I have updated the documentation, VERSION, and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@araghukas araghukas linked an issue Feb 16, 2023 that may be closed by this pull request
Warnings during task execution are assumed to be errors #61
Open
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 50.00% // Head: 49.68% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (c90e6c8) compared to base (dcd5fc2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
- Coverage    50.00%   49.68%   -0.32%     
===========================================
  Files            2        2              
  Lines          160      161       +1     
===========================================
  Hits            80       80              
- Misses          80       81       +1
Impacted Files Coverage Δ
covalent_ssh_plugin/ssh.py 49.37% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@araghukas araghukas mentioned this pull request Oct 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings during task execution are assumed to be errors
1 participant
@araghukas