Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: make "selectable" binding checked on changes #57

Open
conrado-l opened this issue Jun 16, 2019 · 2 comments
Open

Request: make "selectable" binding checked on changes #57

conrado-l opened this issue Jun 16, 2019 · 2 comments

Comments

@conrado-l
Copy link

conrado-l commented Jun 16, 2019

I think it would be a good idea to make the "selectable" input/prop bindable.

I'm making a feature and when there is a loader, I would set "selectable" to false until the loading finishes, I came to realize that the "selectable" input is being checked on ngOnInit, and because of it, it's not bindable.

I think every input or almost every input should be bindable for maximum flexbility.

Thanks for your time and mantaining this awesome library.

@conrado-l conrado-l changed the title Make "selectable" bindable Request: make "selectable" bindable Jun 16, 2019
@AckerApple
Copy link
Owner

Oh I see, it only checks on init. Ok. Maybe make a pull request then please

@AckerApple AckerApple changed the title Request: make "selectable" bindable Request: make "selectable" binding checked on changes Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants