Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expresion and Attribute support in read/write params #157

Open
cerveada opened this issue Sep 6, 2021 · 3 comments
Open

Add Expresion and Attribute support in read/write params #157

cerveada opened this issue Sep 6, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cerveada
Copy link
Contributor

cerveada commented Sep 6, 2021

Since Spark Agent 0.6.3 Expressions and Attributes can be present in read and write operations.

This doesn't cause any issues, but UI doesn't show all available information and/or shows them as raw data.

@wajda wajda self-assigned this Oct 1, 2021
@wajda
Copy link
Contributor

wajda commented Oct 6, 2021

This should be fixed on the server side. Moving the issue to the main Spline repo.

@wajda wajda transferred this issue from AbsaOSS/spline-ui Oct 6, 2021
@wajda
Copy link
Contributor

wajda commented Oct 6, 2021

No, sorry. It's actually a UI issue. Moving it back to the UI repo :)

@wajda wajda transferred this issue from AbsaOSS/spline Oct 6, 2021
@wajda wajda added the bug Something isn't working label Oct 6, 2021
@wajda wajda added this to the 0.7.0 milestone Oct 6, 2021
@wajda
Copy link
Contributor

wajda commented Oct 7, 2021

This is a limitation of the ngx-json-view - nested properties rendering isn't customizable. The UI app makes little assumption about operation properties structure. In this case the atttribute or expression reference is nested to the generic operation parameters that are rendered as a plain JSON.

{
    "properties": {
        "table" : {
            "output": [
                { EXPRESSION }
            ]
        }
    }
}

table.output[0] is a custom property of that specific Write operation, generated by certain version of Spark under certain conditions.
To render it as an expression we either need to expect that that particular property contains an expression metadata and use a separate widget for that, or we need to replace ngx-json-view component with a customizable renderer that would introspect the content of nested properties and render them accordingly to their detected type.

In either case it requires more efforts and because of low priority of the issue I'm moving it out of the scope of this release.

@wajda wajda removed this from the 0.7.0 milestone Oct 7, 2021
@wajda wajda added enhancement New feature or request and removed bug Something isn't working labels Oct 7, 2021
@wajda wajda added this to Spline Mar 31, 2022
@wajda wajda moved this to New in Spline Mar 31, 2022
@wajda wajda moved this from New to Backlog in Spline Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants