Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count when condition is provided is misleading #20

Closed
benedeki opened this issue Feb 12, 2024 · 0 comments · Fixed by #30
Closed

count when condition is provided is misleading #20

benedeki opened this issue Feb 12, 2024 · 0 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@benedeki
Copy link
Contributor

Describe the bug

When asking for record count prividing a condition, the function name count is misleading.
Some more descriptive name would be better.
Deprecate the old function.

Suggested names

  • countOnCondition
  • countWithWhere
@benedeki benedeki added the bug Something isn't working label Feb 12, 2024
benedeki added a commit that referenced this issue Aug 16, 2024
@benedeki
#20: count when condition is provided is misleading
c193b48
@benedeki benedeki mentioned this issue Aug 16, 2024
Merged
@benedeki benedeki moved this from 🆕 To groom to 👀 In review in CPS small repos project Aug 17, 2024
benedeki added a commit that referenced this issue Aug 19, 2024
@benedeki
#20: count when condition is provided is misleading (#30)
8b2b77a
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in CPS small repos project Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#20: count when condition is provided is misleading AbsaOSS/balta
1 participant
@benedeki