Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for S3-based routines #39

Open
dk1844 opened this issue Sep 8, 2020 · 1 comment
Open

Integration tests for S3-based routines #39

dk1844 opened this issue Sep 8, 2020 · 1 comment

Comments

@dk1844
Copy link
Collaborator

dk1844 commented Sep 8, 2020

While #37 solves funcioning of Atum on the S3 persistence layer, it would be quite beneficial in terms of project quality to cover these routines via integration tests as well. (There are unit tests present, but still)

Couple of options come to mind to be able to write sufficient integration tests:

  • localstack, e.g. in form of a testcontainer module or otherwise
  • using a specific library just for s3, maybe Findify's s3mock (This is currently written for SDK v1, but we are using SDK v2 already) or a similar alternative
  • running against a real dedicated S3 bucket set up specifically for S3 integrations tests
  • ?
@lokm01
Copy link
Collaborator

lokm01 commented Sep 8, 2020

@wajda how was this approached in Spline in the end? Did you guys use testcontainer with localstack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants