Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon color does not follow theme change with AppThemeBinding #122

Open
hugebug4ever opened this issue Nov 27, 2024 · 1 comment
Open

Icon color does not follow theme change with AppThemeBinding #122

hugebug4ever opened this issue Nov 27, 2024 · 1 comment
Assignees
Labels
Area-Core Area-Extensions Bug Something isn't working

Comments

@hugebug4ever
Copy link

hugebug4ever commented Nov 27, 2024

Describe the bug
Icon color does not apply the theme color with AppThemeBinding, within the same process.
It only apply on widget creation.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Maui App project with dotnet 9.0
  2. Add an maui icon to the screen
  3. Specify a Icon color to the IconColor property, with AppThemeBinding
  4. Siwthc app theme ( same app instance ), inspcect the icon color
  5. The icon color does not change, but the label color is changed as expected
  6. If I kill the process and restart the app again, the icon color changed as expected.

Expected behavior
The icon color should change with the theme changing.

Screenshots
Code sample:
image
App with light theme:
image
App with dark theme set dynamically:
image

Desktop and Smartphone (please complete the following information):

  • OS: iOS, Windows. (Android should be the same)
  • Version: 4.0.0

Additional context
Add any other context about the problem here.

@AathifMahir AathifMahir self-assigned this Nov 27, 2024
@AathifMahir
Copy link
Owner

Describe the bug
Icon color does not apply the theme color with AppThemeBinding, within the same process.
It only apply on widget creation.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Maui App project with dotnet 9.0
  2. Add an maui icon to the screen
  3. Specify a Icon color to the IconColor property, with AppThemeBinding
  4. Siwthc app theme ( same app instance ), inspcect the icon color
  5. If I restart the app, the color does not change, but the label color is changed as expected

Expected behavior
The icon color should change with the theme changing.

Screenshots
Code sample:
image
App with light theme:
image
App with dark theme set dynamically:
image

Desktop and Smartphone (please complete the following information):

  • OS: iOS, Windows. (Android should be the same)
  • Version: 4.0.0

Additional context
Add any other context about the problem here.

It seems like bug, I'll push a patch to fix this issue as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Core Area-Extensions Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants