From 8ef861f3e1aa9175ccdd5623787193ffd2c578db Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 11:46:36 +0530 Subject: [PATCH 01/11] Fixed Binding Issue on Release --- .../Extensions/BaseIconExtension.cs | 41 +++++++++++++------ 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/src/MauiIcons.Core/Extensions/BaseIconExtension.cs b/src/MauiIcons.Core/Extensions/BaseIconExtension.cs index ea0efc4..1c15f34 100644 --- a/src/MauiIcons.Core/Extensions/BaseIconExtension.cs +++ b/src/MauiIcons.Core/Extensions/BaseIconExtension.cs @@ -5,7 +5,7 @@ namespace MauiIcons.Core; [ContentProperty(nameof(Icon))] -public abstract class BaseIconExtension : BindableObject, IMarkupExtension where TEnum : Enum +public abstract class BaseIconExtension : BindableObject, IMarkupExtension where TEnum : Enum { public static readonly BindableProperty IconProperty = BindableProperty.Create(nameof(Icon), typeof(TEnum?), typeof(BaseIconExtension), null); public static readonly BindableProperty IconSizeProperty = BindableProperty.Create(nameof(IconSize), typeof(double), typeof(BaseIconExtension), 30.0); @@ -51,10 +51,10 @@ public bool IconAutoScaling [System.ComponentModel.TypeConverter(typeof(ListStringTypeConverter))] public IList OnIdioms { get; set; } = new List(); - public Type? TypeArgument { get; set; } - public object ProvideValue(IServiceProvider serviceProvider) + + public BindingBase ProvideValue(IServiceProvider serviceProvider) { var valueProvider = serviceProvider.GetService() ?? throw new ArgumentException(); Type? returnType = (valueProvider.TargetProperty as BindableProperty)?.ReturnType; @@ -65,7 +65,12 @@ public object ProvideValue(IServiceProvider serviceProvider) return new Binding(); } - object SetMauiIconBasedOnType(object targetObject, Type? returnType) + object IMarkupExtension.ProvideValue(IServiceProvider serviceProvider) + { + return (this as IMarkupExtension).ProvideValue(serviceProvider); + } + + Binding SetMauiIconBasedOnType(object targetObject, Type? returnType) { if(returnType == typeof(Enum)) return SetFontProperties(targetObject, disableConverter: true); @@ -170,18 +175,28 @@ Binding SetFontProperties(object targetObject, bool disableConverter = false) } return new Binding(nameof(Icon), mode: BindingMode.OneWay, converter: !disableConverter ? new EnumToStringConverter() : null, source: this); } - FontImageSource SetImageSourceProperties() + + Binding SetImageSourceProperties() { - var fontImageSource = new FontImageSource(); - fontImageSource.SetBinding(FontImageSource.GlyphProperty, new Binding(nameof(Icon), mode: BindingMode.OneWay, converter: new EnumToStringConverter(), source: this)); - fontImageSource.FontFamily = Icon.GetFontFamily(); - fontImageSource.SetBinding(FontImageSource.SizeProperty, new Binding(nameof(IconSize), source: this, mode: BindingMode.OneWay)); - fontImageSource.SetBinding(FontImageSource.ColorProperty, new Binding(nameof(IconColor), source: this, mode: BindingMode.OneWay, - converter: new DefaultColorConverter(), converterParameter: fontImageSource.Color)); - fontImageSource.SetBinding(FontImageSource.FontAutoScalingEnabledProperty, new Binding(nameof(IconAutoScaling), source: this, mode: BindingMode.OneWay)); - return fontImageSource; + InternalSource = new FontImageSource(); + ((FontImageSource)InternalSource).SetBinding(FontImageSource.GlyphProperty, new Binding(nameof(Icon), mode: BindingMode.OneWay, converter: new EnumToStringConverter(), source: this)); + ((FontImageSource)InternalSource).FontFamily = Icon.GetFontFamily(); + ((FontImageSource)InternalSource).SetBinding(FontImageSource.SizeProperty, new Binding(nameof(IconSize), source: this)); + ((FontImageSource)InternalSource).SetBinding(FontImageSource.ColorProperty, new Binding(nameof(IconColor), source: this, + converter: new DefaultColorConverter(), converterParameter: ((FontImageSource)InternalSource).Color)); + ((FontImageSource)InternalSource).SetBinding(FontImageSource.FontAutoScalingEnabledProperty, new Binding(nameof(IconAutoScaling), source: this)); + return new Binding(nameof(InternalSource), mode: BindingMode.OneWay, source: this); } + public static readonly BindableProperty InternalSourceProperty = BindableProperty.Create(nameof(InternalSource), typeof(ImageSource), typeof(BaseIconExtension), null); + /// + /// This is Used Internally, Don't Use it in XAML or CodeBehind + /// + public ImageSource InternalSource + { + get => (ImageSource)GetValue(InternalSourceProperty); + set => SetValue(InternalSourceProperty, value); + } } From 63efc2c58e4b6ebecc99ff5592283ea4e013af6d Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 11:57:02 +0530 Subject: [PATCH 02/11] TFM Updates --- src/Directory.Build.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 0fed1c2..ad12013 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -8,8 +8,8 @@ - net8.0;net8.0-android;net8.0-ios;net8.0-maccatalyst;net7.0;net7.0-android;net7.0-ios;net7.0-maccatalyst - $(TargetFrameworks);net8.0-windows10.0.19041.0;net7.0-windows10.0.19041.0 + net8.0;net8.0-android;net8.0-ios;net8.0-maccatalyst + $(TargetFrameworks);net8.0-windows10.0.19041.0 From ab2b59b6dfe1f9a1df51092274acbd2559f15f36 Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 11:57:09 +0530 Subject: [PATCH 03/11] TFM --- samples/MauiIcons.Sample/MauiIcons.Sample.csproj | 4 ++-- .../MauiIcons.Modules.UnitTest.csproj | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/samples/MauiIcons.Sample/MauiIcons.Sample.csproj b/samples/MauiIcons.Sample/MauiIcons.Sample.csproj index 892df5a..a979d7f 100644 --- a/samples/MauiIcons.Sample/MauiIcons.Sample.csproj +++ b/samples/MauiIcons.Sample/MauiIcons.Sample.csproj @@ -1,8 +1,8 @@  - net8.0-android;net8.0-ios;net8.0-maccatalyst;net7.0-android;net7.0-ios;net7.0-maccatalyst - $(TargetFrameworks);net8.0-windows10.0.19041.0;net7.0-windows10.0.19041.0 + net8.0-android;net8.0-ios;net8.0-maccatalyst + $(TargetFrameworks);net8.0-windows10.0.19041.0 Exe diff --git a/src/MauiIcons.Modules.UnitTest/MauiIcons.Modules.UnitTest.csproj b/src/MauiIcons.Modules.UnitTest/MauiIcons.Modules.UnitTest.csproj index fdde9d3..88acb47 100644 --- a/src/MauiIcons.Modules.UnitTest/MauiIcons.Modules.UnitTest.csproj +++ b/src/MauiIcons.Modules.UnitTest/MauiIcons.Modules.UnitTest.csproj @@ -1,7 +1,7 @@  - net8.0;net7.0 + net8.0 enable enable true From 09016b21e5db46c433405c89cd42e5f6c2c6bdea Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 12:27:44 +0530 Subject: [PATCH 04/11] Removal of Maui OnPlatform and OnIdiom Support --- .../Extensions/BaseIconExtension.cs | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/MauiIcons.Core/Extensions/BaseIconExtension.cs b/src/MauiIcons.Core/Extensions/BaseIconExtension.cs index 1c15f34..1b55063 100644 --- a/src/MauiIcons.Core/Extensions/BaseIconExtension.cs +++ b/src/MauiIcons.Core/Extensions/BaseIconExtension.cs @@ -51,8 +51,6 @@ public bool IconAutoScaling [System.ComponentModel.TypeConverter(typeof(ListStringTypeConverter))] public IList OnIdioms { get; set; } = new List(); - public Type? TypeArgument { get; set; } - public BindingBase ProvideValue(IServiceProvider serviceProvider) { @@ -65,10 +63,8 @@ public BindingBase ProvideValue(IServiceProvider serviceProvider) return new Binding(); } - object IMarkupExtension.ProvideValue(IServiceProvider serviceProvider) - { - return (this as IMarkupExtension).ProvideValue(serviceProvider); - } + object IMarkupExtension.ProvideValue(IServiceProvider serviceProvider) => + (this as IMarkupExtension).ProvideValue(serviceProvider); Binding SetMauiIconBasedOnType(object targetObject, Type? returnType) { @@ -84,17 +80,14 @@ Binding SetMauiIconBasedOnType(object targetObject, Type? returnType) if (returnType is null && (targetObject is On or OnPlatform or OnPlatform or OnPlatformExtension or OnIdiom or OnIdiom - or OnIdiomExtension) && (TypeArgument == typeof(ImageSource) || TypeArgument == typeof(FontImageSource))) - return SetImageSourceProperties(); - - else if (returnType is null && targetObject is On && (TypeArgument is null || TypeArgument != typeof(ImageSource) || TypeArgument != typeof(FontImageSource))) - throw new MauiIconsExpection("MauiIcons only supports ImageSource or FontImageSource in conjunction with OnPlatform and OnIdiom After Assigning TypeArgument." + - "it is recommended to utilize MauiIcon's integrated OnPlatform or OnIdiom functionalities for optimal compatibility."); + or OnIdiomExtension)) + throw new MauiIconsExpection("MauiIcons doesn't support Maui OnPlatform or OnIdiom," + + "Therefore it is recommended to utilize MauiIcon's integrated Custom OnPlatform or OnIdiom functionalities."); else if (returnType is null && targetObject is Setter) - throw new MauiIconsExpection("MauiIcons doesn't support style setter to be used in conjunction with xaml extension."); + throw new MauiIconsExpection("MauiIcons doesn't support Style Setter to be used in conjunction with Xaml Extension."); - throw new MauiIconsExpection($"MauiIcons extension does not provide {returnType} support"); + throw new MauiIconsExpection($"MauiIcons Extension does not provide {returnType} support"); } Binding SetFontProperties(object targetObject, bool disableConverter = false) From 3092d21979e9d688b8d3c03e205b30cb08f43fcf Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 12:27:51 +0530 Subject: [PATCH 05/11] Sample Update --- samples/MauiIcons.Sample/MainPage.xaml | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/samples/MauiIcons.Sample/MainPage.xaml b/samples/MauiIcons.Sample/MainPage.xaml index e352b38..3fbea29 100644 --- a/samples/MauiIcons.Sample/MainPage.xaml +++ b/samples/MauiIcons.Sample/MainPage.xaml @@ -59,19 +59,8 @@ - - - - - - - - - - - - - + + From 3b2e41b4fd061aa5ce6af72bd464d9fc53a4f5a2 Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 12:30:06 +0530 Subject: [PATCH 06/11] Sample Proj Update --- samples/MauiIcons.Sample/MauiIcons.Sample.csproj | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/samples/MauiIcons.Sample/MauiIcons.Sample.csproj b/samples/MauiIcons.Sample/MauiIcons.Sample.csproj index a979d7f..14a1f60 100644 --- a/samples/MauiIcons.Sample/MauiIcons.Sample.csproj +++ b/samples/MauiIcons.Sample/MauiIcons.Sample.csproj @@ -14,15 +14,15 @@ true - MauiIcons.Sample + MauiIcons Gallery com.companyname.mauiicons.sample 32B5B7F1-9EC0-44BE-ACAE-9AC11F0EEC47 - 1.0 - 1 + 1.2 + 3 11.0 13.1 @@ -32,6 +32,10 @@ 6.5 + + apk + + From 0ddc52d12de4ef0cda4da88788b234e326cc0dff Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 12:45:04 +0530 Subject: [PATCH 07/11] Release Notes Update --- src/MauiIcons.Core/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Cupertino/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Fluent.Filled/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Fluent/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.FontAwesome.Brand/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.FontAwesome.Solid/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.FontAwesome/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Material.Outlined/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Material.Rounded/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Material.Sharp/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.Material/ReleaseNotes.txt | 7 ++++++- src/MauiIcons.SegoeFluent/ReleaseNotes.txt | 7 ++++++- 12 files changed, 72 insertions(+), 12 deletions(-) diff --git a/src/MauiIcons.Core/ReleaseNotes.txt b/src/MauiIcons.Core/ReleaseNotes.txt index e0ffca0..d6c8c6e 100644 --- a/src/MauiIcons.Core/ReleaseNotes.txt +++ b/src/MauiIcons.Core/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Cupertino/ReleaseNotes.txt b/src/MauiIcons.Cupertino/ReleaseNotes.txt index 786e4d6..cfece77 100644 --- a/src/MauiIcons.Cupertino/ReleaseNotes.txt +++ b/src/MauiIcons.Cupertino/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Fluent.Filled/ReleaseNotes.txt b/src/MauiIcons.Fluent.Filled/ReleaseNotes.txt index 4421e35..38f30c4 100644 --- a/src/MauiIcons.Fluent.Filled/ReleaseNotes.txt +++ b/src/MauiIcons.Fluent.Filled/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Fluent/ReleaseNotes.txt b/src/MauiIcons.Fluent/ReleaseNotes.txt index a5a152e..379f04e 100644 --- a/src/MauiIcons.Fluent/ReleaseNotes.txt +++ b/src/MauiIcons.Fluent/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.FontAwesome.Brand/ReleaseNotes.txt b/src/MauiIcons.FontAwesome.Brand/ReleaseNotes.txt index 4a0b0b0..2ea8a7c 100644 --- a/src/MauiIcons.FontAwesome.Brand/ReleaseNotes.txt +++ b/src/MauiIcons.FontAwesome.Brand/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.FontAwesome.Solid/ReleaseNotes.txt b/src/MauiIcons.FontAwesome.Solid/ReleaseNotes.txt index 4a0b0b0..2ea8a7c 100644 --- a/src/MauiIcons.FontAwesome.Solid/ReleaseNotes.txt +++ b/src/MauiIcons.FontAwesome.Solid/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.FontAwesome/ReleaseNotes.txt b/src/MauiIcons.FontAwesome/ReleaseNotes.txt index 4a0b0b0..2ea8a7c 100644 --- a/src/MauiIcons.FontAwesome/ReleaseNotes.txt +++ b/src/MauiIcons.FontAwesome/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Material.Outlined/ReleaseNotes.txt b/src/MauiIcons.Material.Outlined/ReleaseNotes.txt index d11e741..9c30a8b 100644 --- a/src/MauiIcons.Material.Outlined/ReleaseNotes.txt +++ b/src/MauiIcons.Material.Outlined/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Material.Rounded/ReleaseNotes.txt b/src/MauiIcons.Material.Rounded/ReleaseNotes.txt index d11e741..9c30a8b 100644 --- a/src/MauiIcons.Material.Rounded/ReleaseNotes.txt +++ b/src/MauiIcons.Material.Rounded/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Material.Sharp/ReleaseNotes.txt b/src/MauiIcons.Material.Sharp/ReleaseNotes.txt index d11e741..9c30a8b 100644 --- a/src/MauiIcons.Material.Sharp/ReleaseNotes.txt +++ b/src/MauiIcons.Material.Sharp/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.Material/ReleaseNotes.txt b/src/MauiIcons.Material/ReleaseNotes.txt index 80cc2f0..7579889 100644 --- a/src/MauiIcons.Material/ReleaseNotes.txt +++ b/src/MauiIcons.Material/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 diff --git a/src/MauiIcons.SegoeFluent/ReleaseNotes.txt b/src/MauiIcons.SegoeFluent/ReleaseNotes.txt index a244c0c..84ab66f 100644 --- a/src/MauiIcons.SegoeFluent/ReleaseNotes.txt +++ b/src/MauiIcons.SegoeFluent/ReleaseNotes.txt @@ -1,4 +1,9 @@ -v2.2.5 +v3.0.0 +• Critical Fixes for Xaml Markup Binding Support +• Breaking Changes: Removal of Dotnet 7 Support +• Breaking Changes: Removal of Maui OnPlatform and OnIdioms Support Instead Use MauiIcons Integrated Custom OnPlatforms and OnIdioms Feature + +v2.2.5 • New and Improved Xaml Markup Extension with Binding Support v2.1.5 From 1d3ce0b5d2e79520693cfb03cee23044ba4d54a8 Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 12:45:46 +0530 Subject: [PATCH 08/11] Version Bump --- src/Directory.Build.props | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index ad12013..70e25ae 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -29,9 +29,9 @@ MauiIcons icon.png - 2.2.5.0 - 2.2.5.0 - 2.2.5 + 3.0.0.0 + 3.0.0.0 + 3.0.0 $(AssemblyName) ($(TargetFramework)) $(Version)$(VersionSuffix) false From 463d6a3723d840be36f48a459dd57b3813350bde Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 13:06:00 +0530 Subject: [PATCH 09/11] Docs Update --- src/MauiIcons.Cupertino/readme.md | 32 +++++-------------- src/MauiIcons.Fluent.Filled/readme.md | 38 +++++++--------------- src/MauiIcons.Fluent/readme.md | 39 +++++++---------------- src/MauiIcons.FontAwesome.Brand/readme.md | 30 ++++------------- src/MauiIcons.FontAwesome.Solid/readme.md | 30 ++++------------- src/MauiIcons.FontAwesome/readme.md | 30 ++++------------- src/MauiIcons.Material.Outlined/readme.md | 30 ++++------------- src/MauiIcons.Material.Rounded/readme.md | 31 ++++-------------- src/MauiIcons.Material.Sharp/readme.md | 31 ++++-------------- src/MauiIcons.Material/readme.md | 38 +++++++--------------- src/MauiIcons.SegoeFluent/readme.md | 38 +++++++--------------- 11 files changed, 95 insertions(+), 272 deletions(-) diff --git a/src/MauiIcons.Cupertino/readme.md b/src/MauiIcons.Cupertino/readme.md index 6531db3..8d39105 100644 --- a/src/MauiIcons.Cupertino/readme.md +++ b/src/MauiIcons.Cupertino/readme.md @@ -52,7 +52,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` @@ -70,6 +72,11 @@ xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -161,29 +168,6 @@ new MauiIcon().Icon(CupertinoIcons.Airplane).OnIdioms(new List{"Desktop" new MauiIcon().Icon(CupertinoIcons.AntFill).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.Cupertino** diff --git a/src/MauiIcons.Fluent.Filled/readme.md b/src/MauiIcons.Fluent.Filled/readme.md index 94de34f..ab5c5ca 100644 --- a/src/MauiIcons.Fluent.Filled/readme.md +++ b/src/MauiIcons.Fluent.Filled/readme.md @@ -52,14 +52,16 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` ```xml -xmlns:fluentFilled="clr-namespace:MauiIcons.FluentFilled;assembly=MauiIcons.FluentFilled" +xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" - + ``` `New (v2)` @@ -67,9 +69,14 @@ xmlns:fluentFilled="clr-namespace:MauiIcons.FluentFilled;assembly=MauiIcons.Flue ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ### Nuget Package Changes - **`AathifMahir.Maui.MauiIcons.FluentFilled`** is Depcrecated and Replaced by [`AathifMahir.Maui.MauiIcons.Fluent.Filled`](https://www.nuget.org/packages/AathifMahir.Maui.MauiIcons.Fluent.Filled/) @@ -165,29 +172,6 @@ new MauiIcon().Icon(FluentFilledIcons.Accessibility48Filled).OnIdioms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.Fluent.Filled** diff --git a/src/MauiIcons.Fluent/readme.md b/src/MauiIcons.Fluent/readme.md index ef705f6..3a2beae 100644 --- a/src/MauiIcons.Fluent/readme.md +++ b/src/MauiIcons.Fluent/readme.md @@ -52,14 +52,16 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` ```xml -xmlns:fluent="clr-namespace:MauiIcons.Fluent;assembly=MauiIcons.Fluent" +xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" - + ``` `New (v2)` @@ -67,9 +69,15 @@ xmlns:fluent="clr-namespace:MauiIcons.Fluent;assembly=MauiIcons.Fluent" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + + ## Built in Control Usage `Xaml` @@ -161,29 +169,6 @@ new MauiIcon().Icon(FluentIcons.Accessibility48).OnIdioms(new List{"Desk new MauiIcon().Icon(FluentIcons.AppFolder48).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.Fluent** diff --git a/src/MauiIcons.FontAwesome.Brand/readme.md b/src/MauiIcons.FontAwesome.Brand/readme.md index 5dbb46d..d1843bd 100644 --- a/src/MauiIcons.FontAwesome.Brand/readme.md +++ b/src/MauiIcons.FontAwesome.Brand/readme.md @@ -52,6 +52,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -143,29 +150,6 @@ new MauiIcon().Icon(FontAwesomeBrandIcons.Github).OnIdioms(new List{"Des new MauiIcon().Icon(FontAwesomeBrandIcons.PenToSquare).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.FontAwesome.Brand** diff --git a/src/MauiIcons.FontAwesome.Solid/readme.md b/src/MauiIcons.FontAwesome.Solid/readme.md index 3b1ac9e..dcba378 100644 --- a/src/MauiIcons.FontAwesome.Solid/readme.md +++ b/src/MauiIcons.FontAwesome.Solid/readme.md @@ -52,6 +52,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -143,29 +150,6 @@ new MauiIcon().Icon(FontAwesomeSolidIcons.Asterisk).OnIdioms(new List{"D new MauiIcon().Icon(FontAwesomeSolidIcons.PenToSquare).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.FontAwesome.Solid** diff --git a/src/MauiIcons.FontAwesome/readme.md b/src/MauiIcons.FontAwesome/readme.md index b37c520..b97121e 100644 --- a/src/MauiIcons.FontAwesome/readme.md +++ b/src/MauiIcons.FontAwesome/readme.md @@ -52,6 +52,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -143,29 +150,6 @@ new MauiIcon().Icon(FontAwesomeIcons.Asterisk).OnIdioms(new List{"Deskto new MauiIcon().Icon(FontAwesomeIcons.PenToSquare).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.FontAwesome** diff --git a/src/MauiIcons.Material.Outlined/readme.md b/src/MauiIcons.Material.Outlined/readme.md index e3aa69d..5caf1d2 100644 --- a/src/MauiIcons.Material.Outlined/readme.md +++ b/src/MauiIcons.Material.Outlined/readme.md @@ -52,6 +52,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -143,29 +150,6 @@ new MauiIcon().Icon(MaterialOutlinedIcons.ABC).OnIdioms(new List{"Deskto new MauiIcon().Icon(MaterialOutlinedIcons.AddRoad).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.Material.Outlined** diff --git a/src/MauiIcons.Material.Rounded/readme.md b/src/MauiIcons.Material.Rounded/readme.md index 88b6eef..b691e32 100644 --- a/src/MauiIcons.Material.Rounded/readme.md +++ b/src/MauiIcons.Material.Rounded/readme.md @@ -51,6 +51,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage @@ -143,30 +150,6 @@ new MauiIcon().Icon(MaterialRoundedIcons.ABC).OnIdioms(new List{"Desktop new MauiIcon().Icon(MaterialRoundedIcons.AddRoad).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - - # License **MauiIcons.Material.Rounded** diff --git a/src/MauiIcons.Material.Sharp/readme.md b/src/MauiIcons.Material.Sharp/readme.md index 43cddf2..2e01933 100644 --- a/src/MauiIcons.Material.Sharp/readme.md +++ b/src/MauiIcons.Material.Sharp/readme.md @@ -52,6 +52,13 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` +## Breaking Changes + +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -143,30 +150,6 @@ new MauiIcon().Icon(MaterialSharpIcons.ABC).OnIdioms(new List{"Desktop", new MauiIcon().Icon(MaterialSharpIcons.AddRoad).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - - # License **MauiIcons.Material.Sharp** diff --git a/src/MauiIcons.Material/readme.md b/src/MauiIcons.Material/readme.md index 89cfeea..9158a1d 100644 --- a/src/MauiIcons.Material/readme.md +++ b/src/MauiIcons.Material/readme.md @@ -52,14 +52,16 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` ```xml -xmlns:material="clr-namespace:MauiIcons.Material;assembly=MauiIcons.Material" +xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" - + ``` `New (v2)` @@ -67,9 +69,14 @@ xmlns:material="clr-namespace:MauiIcons.Material;assembly=MauiIcons.Material" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ### Nuget Package Changes - **`AathifMahir.Maui.MauiIcons.Material`** doesn't contain all the Variants anymore, Now only contains **Regular version** of Material Icons. Other Variants Decoupled into Seperate Packages Like Below @@ -169,29 +176,6 @@ new MauiIcon().Icon(MaterialIcons.ABC).OnIdioms(new List{"Desktop", "Pho new MauiIcon().Icon(MaterialIcons.AddRoad).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.Material** diff --git a/src/MauiIcons.SegoeFluent/readme.md b/src/MauiIcons.SegoeFluent/readme.md index aaf3d0d..d8c7599 100644 --- a/src/MauiIcons.SegoeFluent/readme.md +++ b/src/MauiIcons.SegoeFluent/readme.md @@ -52,14 +52,16 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` ```xml -xmlns:segoeFluent="clr-namespace:MauiIcons.SegoeFluent;assembly=MauiIcons.SegoeFluent" +xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" - + ``` `New (v2)` @@ -67,9 +69,14 @@ xmlns:segoeFluent="clr-namespace:MauiIcons.SegoeFluent;assembly=MauiIcons.SegoeF ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ## Built in Control Usage `Xaml` @@ -161,29 +168,6 @@ new MauiIcon().Icon(SegoeFluentIcons.AdjustHologram).OnIdioms(new List{" new MauiIcon().Icon(SegoeFluentIcons.ActionCenterQuiet).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # License **MauiIcons.SegoeFluent** From b95d345adc52caa7fd4801ccb6e5f38ab032ffeb Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 13:13:49 +0530 Subject: [PATCH 10/11] Docs Update --- src/MauiIcons.Fluent.Filled/readme.md | 6 +++--- src/MauiIcons.Fluent/readme.md | 6 +++--- src/MauiIcons.Material/readme.md | 6 +++--- src/MauiIcons.SegoeFluent/readme.md | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/MauiIcons.Fluent.Filled/readme.md b/src/MauiIcons.Fluent.Filled/readme.md index ab5c5ca..3f8cfcf 100644 --- a/src/MauiIcons.Fluent.Filled/readme.md +++ b/src/MauiIcons.Fluent.Filled/readme.md @@ -59,9 +59,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su `Old (v1)` ```xml -xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" +xmlns:fluentFilled="clr-namespace:MauiIcons.Fluent.Filled;assembly=MauiIcons.Fluent.Filled" - + ``` `New (v2)` @@ -69,7 +69,7 @@ xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` ### Version 2 to 3 diff --git a/src/MauiIcons.Fluent/readme.md b/src/MauiIcons.Fluent/readme.md index 3a2beae..3288a76 100644 --- a/src/MauiIcons.Fluent/readme.md +++ b/src/MauiIcons.Fluent/readme.md @@ -59,9 +59,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su `Old (v1)` ```xml -xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" +xmlns:fluent="clr-namespace:MauiIcons.Fluent;assembly=MauiIcons.Fluent" - + ``` `New (v2)` @@ -69,7 +69,7 @@ xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` ### Version 2 to 3 diff --git a/src/MauiIcons.Material/readme.md b/src/MauiIcons.Material/readme.md index 9158a1d..556b470 100644 --- a/src/MauiIcons.Material/readme.md +++ b/src/MauiIcons.Material/readme.md @@ -59,9 +59,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su `Old (v1)` ```xml -xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" +xmlns:material="clr-namespace:MauiIcons.Material;assembly=MauiIcons.Material" - + ``` `New (v2)` @@ -69,7 +69,7 @@ xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` ### Version 2 to 3 diff --git a/src/MauiIcons.SegoeFluent/readme.md b/src/MauiIcons.SegoeFluent/readme.md index d8c7599..7452599 100644 --- a/src/MauiIcons.SegoeFluent/readme.md +++ b/src/MauiIcons.SegoeFluent/readme.md @@ -59,9 +59,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su `Old (v1)` ```xml -xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" +xmlns:segoeFluent="clr-namespace:MauiIcons.SegoeFluent;assembly=MauiIcons.SegoeFluent" - + ``` `New (v2)` @@ -69,7 +69,7 @@ xmlns:cupertino="clr-namespace:MauiIcons.Cupertino;assembly=MauiIcons.Cupertino" ```xml xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" - + ``` ### Version 2 to 3 From 3b08cc7a9ac76853f5055c21517f61758569d24c Mon Sep 17 00:00:00 2001 From: Aathif_Mahir Date: Sat, 11 May 2024 13:13:58 +0530 Subject: [PATCH 11/11] Global Docs Update --- README.md | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index c8a3d19..de77b54 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,9 @@ if you came across this issue dotnet/maui#7503 when using new namespace, Make su ``` -## Breaking Changes from v2 +## Breaking Changes + +### Version 1 to 2 `Old (v1)` @@ -91,6 +93,11 @@ xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons" ``` +### Version 2 to 3 + + - Removal of **TypeArgument** and Built in OnPlatform and OnIdiom Support, Use MauiIcons Integrated [Custom OnPlatform and OnIdioms Feature](#custom-onplatform-and-onidiom-usage) + - Removal of **Dotnet 7** Support + ### Nuget Package Changes - **`AathifMahir.Maui.MauiIcons.Material`** doesn't contain all the Variants anymore, Now only contains **Regular version** of Material Icons. Other Variants Decoupled into Seperate Packages Like Below @@ -243,29 +250,6 @@ new MauiIcon().Icon(FluentIcons.Accounts).OnIdioms(new List{"Desktop", " new MauiIcon().Icon(MaterialIcons.ABC).OnPlatforms(new List{"WinUI", "Android"}).OnIdioms(new List{"Desktop", "Phone"}); ``` -## Maui Built in OnPlatform and OnIdiom Usage - -```xml - - - - - - - - - - - - - - - -``` -**Disclaimer:** Only **ImageSource** or **FontImageSource** Supports Maui's Built in OnPlatform or OnIdiom and **TypeArgument** Should be Assigned to Work Optimally, Therefore It's Recommended to use MauiIcons Custom OnPlatform and OnIdioms - # Properties | Parameters | Type | Description |