Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link won't save if scheme is missing #33

Open
mberry opened this issue Sep 6, 2023 · 1 comment
Open

Link won't save if scheme is missing #33

mberry opened this issue Sep 6, 2023 · 1 comment

Comments

@mberry
Copy link
Collaborator

mberry commented Sep 6, 2023

No error raised, simply ignores the entry.

Would suggest to allow entries without the scheme, default to http and handle the result.

An incorrect scheme will save but raises an error with metadata.

@kirillt
Copy link
Member

kirillt commented Sep 14, 2023

Would suggest to allow entries without the scheme, default to http and handle the result.

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants