Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary sign updates #671

Open
TylerS1066 opened this issue Jul 21, 2024 · 1 comment · May be fixed by #697
Open

Remove unnecessary sign updates #671

TylerS1066 opened this issue Jul 21, 2024 · 1 comment · May be fixed by #697
Labels
code health Issues that don't necisarily pertain to end users but instead relate to code releated issues enhancement

Comments

@TylerS1066
Copy link
Contributor

With the merging of #670, all signs are now updated on translation and rotation. To prevent unnecessary sign updates and improve performance, we should find a way to fake out the client to think the sign updated without going through the work of actually updating it.
@TylerS1066 TylerS1066 added enhancement code health Issues that don't necisarily pertain to end users but instead relate to code releated issues labels Jul 21, 2024
@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage Jul 21, 2024
@Intybyte
Copy link
Contributor

Intybyte commented Aug 4, 2024 •
edited
Loading

For now I implemented a Patch and plan to implement similar ones in this repository, it would be good if there was a way to fix this without protcol lib, it uses bytecode manipulation to replace the sendSignEvents() method. (I think it works but i hope nobody actually runs this on a server)

@Intybyte Intybyte linked a pull request Aug 20, 2024 that will close this issue
Open
2 tasks
@TylerS1066 TylerS1066 mentioned this issue Sep 8, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Issues that don't necisarily pertain to end users but instead relate to code releated issues enhancement
Projects
Issue Triage
Status: Ready for Work
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Playerside sign update Intybyte/Movecraft-fixes
2 participants
@TylerS1066 @Intybyte