Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water outside of hitboxes #554

Open
goodroach opened this issue Oct 3, 2022 · 3 comments
Open

Water outside of hitboxes #554

goodroach opened this issue Oct 3, 2022 · 3 comments

Comments

@goodroach
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, water / lava can flow out of a hitbox of a ship. So allow us to turn it off. This feature will prevent ships being stuck, as well as prevent certain ships from griefing other ships by dropping water or lava on them.

Describe the solution you'd like
Utilize fluidLevelChangeEvent (not sure if this is good for 1.13 but I know 1.19 is ok) to check if the fluid on event is out of the hitbox of a ship. Once the ship translates, then the water should probably disappear. Though that's going to be harder to implement.

@TylerS1066
Copy link
Contributor

I believe the intent of BlockListerner#onBlockFromTo() is to do just this, but maybe it's not functioning?

@goodroach
Copy link
Contributor Author

Well currently, I can just drop water from my ship using a dispenser system onto other ships so I can completely disable it. The workaround for this currently is to make ships go through water, which isn't a problem for my server but for a server with some water it would mean all airships are submersible.

@TylerS1066
Copy link
Contributor

I thought this problem was water flowing out of a craft's hitbox (like the intent of the above function), not a dispenser dispensing water outside of the hitbox. The second is much harder to detect.

@TylerS1066 TylerS1066 moved this from New to In Discussion in Issue Triage Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Discussion
Development

No branches or pull requests

2 participants