Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS class prefixing #18

Open
amenk opened this issue May 24, 2013 · 2 comments
Open

CSS class prefixing #18

amenk opened this issue May 24, 2013 · 2 comments

Comments

@amenk
Copy link
Contributor

amenk commented May 24, 2013

I found that in the tool tip there is a class=header used - we have a style .header in the shop, so the shop header is placed in the tool tip.

I think we should prefix the CSS classes of the tooltips to avoid that - it does not really make sense to adapt the shop CSS for the template hints, as they are usually added "on top" or temporarily only.
@amenk
Copy link
Contributor Author

amenk commented May 24, 2013

just saw that this header class comes from deep inside of the opentip.js script :-/

amenk added a commit to amenk/Aoe_TemplateHints that referenced this issue May 24, 2013
@amenk
Fix: AOEpeople#18 - More explicit tool tip styles
928f3ac 
The tool tip is using classes content and body which are often
have site-specific styles.

Some common values (background, font, color) are now reset.
@amenk
Copy link
Contributor Author

amenk commented May 24, 2013

My pull request should fix that ...

fbrnc added a commit that referenced this issue Jun 12, 2013
@fbrnc
Merge pull request #19 from amenk/css-fixes
6b79c4a 
Fix: #18 - More explicit tool tip styles

Looks good to me. Merged. Thanks for the contribution! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amenk